Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Making them opaque seemed like a nice idea, because all the indexers
could take care of their own command-line arguments. However, it
doesn't work at all when indexing is run via the API.
|
|
|
|
Closes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/41
|
|
|
|
Only when using PinkIndexer.
Closes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/25
|
|
|
|
|
|
The problem is, '(null)' is not NULL.
|
|
|
|
This makes it consistent with all the other windows.
|
|
|
|
They need to be prefixed with "../" because they are in a different
folder.
|
|
I find that starting to show centres at a higher magnification level
makes it easier to distinguish the centre markers from bright pixels.
|
|
|
|
Smaller numbers of crystals are more common, so it's better for the
second crystal to be something very distinct from the peak search
colour.
|
|
|
|
|
|
This allows project folders to be relocated more easily.
At the same time, I fixed the weird ownership semantics of
add_indexing_result and add_merge_result.
Fixes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/31
|
|
Big improvement on just sending NAN back.
Fixes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/37
|
|
|
|
Closes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/11
|
|
|
|
Prompted by the article linked below, for each FIXME/TODO I've either
referenced an issue in the tracker, or removed it if it's not worth
fixing.
https://schleiss.io/plotting-source-code-todos-for-open-source-projects
|
|
|
|
Rationale: it makes the JSON structure a bit more logical, and enables
things like the following:
set_of_params_1.integration.radii == set_of_params_2.integration.radii
params.peaksearch.radii == params.integration.radii
Previously, these would have required multiple comparisons.
|
|
Apparently, I can't count.
|
|
|
|
Previously, they would not get scanned because no job was running. We
need one more scan after a job exits to make sure everything is up to
date.
|
|
Closes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/13
|
|
|
|
|
|
|
|
This (re-)adds the ability to get data via a request/reply socket.
See afcb7b568947c for when it was removed.
|
|
This fixes --threshold when --zmq-subscribe is used.
|
|
Closes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/12
|
|
|
|
A silly cut+paste error.
|
|
The logic behind forcing the results selector (to "Calculations within
GUI") was that anything calculated in the GUI should appear under that
selection only.
Unfortunately, when loading a stream without images, there is nothing at
all to be seen under this selection, not even an image. Forcing the
selector resulted in proj->cur_image = NULL and therefore a crash when
trying to index based on that.
Similarly, the call to update_peaks expected image data, but there is
none. In reality, we have a perfectly good image structure with peaks
from the stream already.
This allows a non-image stream to be "re-indexed" based on the peaks.
Fixes: https://gitlab.desy.de/thomas.white/crystfel/-/issues/33
|
|
|
|
|
|
The unique filename is needed by the GUI for looking up results in a
stream. Otherwise, the filename is "(null)" for everything and the
lookup just returns the first chunk in the stream.
The filename is generated based on the unique serial number for each
chunk, and is therefore unique across one run of indexamajig regardless
of the number of worker processes (-j). This might have to change in future
to accommodate jobs run across multiple nodes, if there is any demand
for looking at results in one big concatenated stream.
This also changes the condition for deciding when to look for a 'real'
file, to take into account that there is always a non-NULL filename.
|
|
This is a hack to filter out what seems like "keepalive" messages. It's
nasty, but better than contaminating the stream with spurious chunks.
|
|
|