aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>2008-09-03 11:26:39 +0800
committerJohn W. Linville <linville@tuxdriver.com>2008-09-08 14:23:18 -0400
commit926f0b2ef24041db876ec7213fbddd7cd4555951 (patch)
tree694ca2aa5b65bc7f9516333b80d0e7a61388ae30
parent6e21f2c109edd746a10e08186484bae8168cdd0c (diff)
iwlwifi: fix strict_strtoul error checking
This patch fixes handling of strcit_strtoul return value "0 == sucess". Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Zhu Yi <yi.zhu@intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/iwlwifi/iwl-agn.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index b9798fa519f..ffaf3f2e8a9 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -3726,7 +3726,7 @@ static ssize_t store_flags(struct device *d,
unsigned long val;
u32 flags;
int ret = strict_strtoul(buf, 0, &val);
- if (!ret)
+ if (ret)
return ret;
flags = (u32)val;
@@ -3765,7 +3765,7 @@ static ssize_t store_filter_flags(struct device *d,
unsigned long val;
u32 filter_flags;
int ret = strict_strtoul(buf, 0, &val);
- if (!ret)
+ if (ret)
return ret;
filter_flags = (u32)val;
@@ -3905,7 +3905,7 @@ static ssize_t store_power_level(struct device *d,
}
ret = strict_strtoul(buf, 10, &mode);
- if (!ret)
+ if (ret)
goto out;
ret = iwl_power_set_user_mode(priv, mode);