aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVlad Yasevich <vladislav.yasevich@hp.com>2007-05-09 13:50:20 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2007-05-10 23:45:29 -0700
commit8dc4984a6bdcaf56cdb458a7338c32c16f32540c (patch)
tree565bd6c7090ac424fc4239537f03bc6ba86ea99b
parentd9568ba91b1fdd1ea4fdbf9fcc76b867cca6c1d5 (diff)
[SCTP]: Prevent OOPS if hmac modules didn't load
SCTP was checking for NULL when trying to detect hmac allocation failure where it should have been using IS_ERR. Also, print a rate limited warning to the log telling the user what happend. Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/sctp/socket.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 83a76ba9d7b..f3c95f9bd41 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -5227,7 +5227,12 @@ int sctp_inet_listen(struct socket *sock, int backlog)
/* Allocate HMAC for generating cookie. */
if (sctp_hmac_alg) {
tfm = crypto_alloc_hash(sctp_hmac_alg, 0, CRYPTO_ALG_ASYNC);
- if (!tfm) {
+ if (IS_ERR(tfm)) {
+ if (net_ratelimit()) {
+ printk(KERN_INFO
+ "SCTP: failed to load transform for %s: %ld\n",
+ sctp_hmac_alg, PTR_ERR(tfm));
+ }
err = -ENOSYS;
goto out;
}