aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEugene Teo <eugene.teo@eugeneteo.net>2006-03-17 16:32:52 +0100
committerJaroslav Kysela <perex@suse.cz>2006-03-22 10:39:25 +0100
commitd61975fc6b40dadd2cd61fc9535499c7d7b806de (patch)
treea3203048ad4b84ba10b1337902d9d08010b902c7
parente64d2e36236175a56fd1d8b2acd784e21bdc7de6 (diff)
[ALSA] Fix gus_pcm dereference before NULL
Modules: GUS Library The NULL check of substream is simply superfluous. It is guaranteed to receive non-NULL substream. Thanks Takashi. Coverity bug #861 Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/isa/gus/gus_pcm.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/sound/isa/gus/gus_pcm.c b/sound/isa/gus/gus_pcm.c
index d0829393ec8..c7f95e7aa01 100644
--- a/sound/isa/gus/gus_pcm.c
+++ b/sound/isa/gus/gus_pcm.c
@@ -114,8 +114,6 @@ static void snd_gf1_pcm_trigger_up(struct snd_pcm_substream *substream)
unsigned char pan;
unsigned int voice;
- if (substream == NULL)
- return;
spin_lock_irqsave(&pcmp->lock, flags);
if (pcmp->flags & SNDRV_GF1_PCM_PFLG_ACTIVE) {
spin_unlock_irqrestore(&pcmp->lock, flags);