aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBill Pemberton <wfp5p@virginia.edu>2009-07-28 13:46:22 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2009-09-15 12:01:52 -0700
commit2295ba2e7c4141e864f66830b07e635245233a3d (patch)
tree171fce7ebd2a1a770b98b7825d0d31d5b76abccc
parent3d3b5518a35fa3c31b74224d944cbc83302c5ab4 (diff)
Staging: hv: check return value of driver_for_each_device()
The return value of driver_for_each_device() is now checked. A non-zero value simply generates a warning message, but it's better than not checking at all. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/staging/hv/blkvsc_drv.c11
-rw-r--r--drivers/staging/hv/netvsc_drv.c11
-rw-r--r--drivers/staging/hv/storvsc_drv.c10
3 files changed, 26 insertions, 6 deletions
diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c
index d595c3b9cdf..dff950b591c 100644
--- a/drivers/staging/hv/blkvsc_drv.c
+++ b/drivers/staging/hv/blkvsc_drv.c
@@ -218,8 +218,8 @@ void blkvsc_drv_exit(void)
{
STORVSC_DRIVER_OBJECT *storvsc_drv_obj=&g_blkvsc_drv.drv_obj;
struct driver_context *drv_ctx=&g_blkvsc_drv.drv_ctx;
-
struct device *current_dev=NULL;
+ int ret;
DPRINT_ENTER(BLKVSC_DRV);
@@ -228,7 +228,14 @@ void blkvsc_drv_exit(void)
current_dev = NULL;
/* Get the device */
- driver_for_each_device(&drv_ctx->driver, NULL, (void*)&current_dev, blkvsc_drv_exit_cb);
+ ret = driver_for_each_device(&drv_ctx->driver, NULL,
+ (void *) &current_dev,
+ blkvsc_drv_exit_cb);
+
+ if (ret)
+ DPRINT_WARN(BLKVSC_DRV,
+ "driver_for_each_device returned %d", ret);
+
if (current_dev == NULL)
break;
diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c
index f0df216028a..9010f0e2ce6 100644
--- a/drivers/staging/hv/netvsc_drv.c
+++ b/drivers/staging/hv/netvsc_drv.c
@@ -638,8 +638,8 @@ void netvsc_drv_exit(void)
{
NETVSC_DRIVER_OBJECT *netvsc_drv_obj=&g_netvsc_drv.drv_obj;
struct driver_context *drv_ctx=&g_netvsc_drv.drv_ctx;
-
struct device *current_dev=NULL;
+ int ret;
DPRINT_ENTER(NETVSC_DRV);
@@ -648,7 +648,14 @@ void netvsc_drv_exit(void)
current_dev = NULL;
/* Get the device */
- driver_for_each_device(&drv_ctx->driver, NULL, (void*)&current_dev, netvsc_drv_exit_cb);
+ ret = driver_for_each_device(&drv_ctx->driver, NULL,
+ (void *) &current_dev,
+ netvsc_drv_exit_cb);
+
+ if (ret)
+ DPRINT_WARN(NETVSC_DRV,
+ "driver_for_each_device returned %d", ret);
+
if (current_dev == NULL)
break;
diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
index 385e84bd52c..120ec52fe9f 100644
--- a/drivers/staging/hv/storvsc_drv.c
+++ b/drivers/staging/hv/storvsc_drv.c
@@ -188,8 +188,8 @@ void storvsc_drv_exit(void)
{
STORVSC_DRIVER_OBJECT *storvsc_drv_obj=&g_storvsc_drv.drv_obj;
struct driver_context *drv_ctx=&g_storvsc_drv.drv_ctx;
-
struct device *current_dev=NULL;
+ int ret;
DPRINT_ENTER(STORVSC_DRV);
@@ -198,7 +198,13 @@ void storvsc_drv_exit(void)
current_dev = NULL;
/* Get the device */
- driver_for_each_device(&drv_ctx->driver, NULL, (void*)&current_dev, storvsc_drv_exit_cb);
+ ret = driver_for_each_device(&drv_ctx->driver, NULL,
+ (void *) &current_dev,
+ storvsc_drv_exit_cb);
+
+ if (ret)
+ DPRINT_WARN(STORVSC_DRV,
+ "driver_for_each_device returned %d", ret);
if (current_dev == NULL)
break;