aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNaranjo Manuel Francisco <naranjo.manuel@gmail.com>2006-11-15 15:14:27 -0300
committerGreg Kroah-Hartman <gregkh@suse.de>2006-12-01 14:23:35 -0800
commit7a5c7b42d3c7b1e0085d48414ee73003d3888d1f (patch)
treeac23aa6a0c81e9e79b5788e81ac6c9f84cc5d17b
parent1b7be3c066ae9238996a7a861b39b0bfd5860735 (diff)
USB: fix aircable.c: inconsequent NULL checking
> 2006/11/11, Adrian Bunk <bunk@stusta.de>: > > The Coverity checker spotted the following in > > drivers/usb/serial/aircable.c: > > > > <-- snip --> > > > > ... > > static void aircable_read(void *params) > > { > > ... Hi everyone, Sorry for the long time response but here is the patch, I think this way should work, if anyone has any suggestion let me know. What I do now is, in case I don't have the tty available I reschedule the work, I have tried it and it works with no problem, I even tried removing the device, and didn't find anything strange. Signed-off-by: Naranjo Manuel <naranjo.manuel@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/serial/aircable.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/usb/serial/aircable.c b/drivers/usb/serial/aircable.c
index 8554c1a7b9f..b1b5707bc99 100644
--- a/drivers/usb/serial/aircable.c
+++ b/drivers/usb/serial/aircable.c
@@ -270,8 +270,11 @@ static void aircable_read(void *params)
*/
tty = port->tty;
- if (!tty)
+ if (!tty) {
schedule_work(&priv->rx_work);
+ err("%s - No tty available", __FUNCTION__);
+ return ;
+ }
count = min(64, serial_buf_data_avail(priv->rx_buf));