aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJiri Slaby <jirislaby@gmail.com>2006-12-08 02:38:17 -0800
committerLinus Torvalds <torvalds@woody.osdl.org>2006-12-08 08:28:53 -0800
commit06cc86b5bd4edcf5e7d68624f7d5c9951916f3d1 (patch)
tree3e6069bdfc681ca2e240c71129a0b56c933831f3
parent7a7a5c3303a66c9000f270d6dd03ddeda8c80768 (diff)
[PATCH] Char: mxser_new, kill unneeded memsets
mxser_new, kill unneeded memsets There is no need to re-zero static global variables' memory, hence memsets doing this are useless. alloc_tty_struct also zeroes allocated memory: another candidate for removing. This fixes also a bug -- global structures are cleaned up after initialization of some its parts. Signed-off-by: Jiri Slaby <jirislaby@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--drivers/char/mxser_new.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/char/mxser_new.c b/drivers/char/mxser_new.c
index 5a4c80d38c6..4ca97c4401d 100644
--- a/drivers/char/mxser_new.c
+++ b/drivers/char/mxser_new.c
@@ -704,7 +704,6 @@ static int __init mxser_init(void)
MXSER_VERSION);
/* Initialize the tty_driver structure */
- memset(mxvar_sdriver, 0, sizeof(struct tty_driver));
mxvar_sdriver->magic = TTY_DRIVER_MAGIC;
mxvar_sdriver->name = "ttyM";
mxvar_sdriver->major = ttymajor;
@@ -721,12 +720,6 @@ static int __init mxser_init(void)
mxvar_sdriver->termios_locked = mxvar_termios_locked;
mxvar_diagflag = 0;
- memset(mxser_boards, 0, sizeof(mxser_boards));
- memset(&mxvar_log, 0, sizeof(struct mxser_log));
-
- memset(&mxser_msr, 0, sizeof(unsigned char) * (MXSER_PORTS + 1));
- memset(&mon_data_ext, 0, sizeof(struct mxser_mon_ext));
- memset(&mxser_set_baud_method, 0, sizeof(int) * (MXSER_PORTS + 1));
m = 0;
/* Start finding ISA boards here */