aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeoff Levand <geoffrey.levand@am.sony.com>2007-01-26 19:08:16 -0800
committerPaul Mackerras <paulus@samba.org>2007-02-07 14:03:18 +1100
commit577157659fb0ace3b88dd75e2c6cb1af84b3040d (patch)
tree280d3f809a17c8db3ff521d369e3eb63e354f7ac
parentb1eeb38e456281c37bbfc270a6ca08605b7e7045 (diff)
[POWERPC] ps3: fix interrupt bmp
Add a comment and a preprocessor macro to help clearify the alignment needs of the PS3 interrupt bitmap. Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> Acked-by: Arnd Bergmann <arnd.bergmann@de.ibm.com> Signed-off-by: Paul Mackerras <paulus@samba.org>
-rw-r--r--arch/powerpc/platforms/ps3/interrupt.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/arch/powerpc/platforms/ps3/interrupt.c b/arch/powerpc/platforms/ps3/interrupt.c
index 3735cd14f61..95b128ba908 100644
--- a/arch/powerpc/platforms/ps3/interrupt.c
+++ b/arch/powerpc/platforms/ps3/interrupt.c
@@ -48,6 +48,9 @@
* behalf of the guest. These mappings are implemented as 256 bit guest
* supplied bitmaps indexed by plug number. The addresses of the bitmaps
* are registered with the HV through lv1_configure_irq_state_bitmap().
+ * The HV requires that the 512 bits of status + mask not cross a page
+ * boundary. PS3_BMP_MINALIGN is used to define this minimal 64 byte
+ * alignment.
*
* The HV supports 256 plugs per thread, assigned as {0..255}, for a total
* of 512 plugs supported on a processor. To simplify the logic this
@@ -59,6 +62,8 @@
* can acquire.
*/
+#define PS3_BMP_MINALIGN 64
+
struct ps3_bmp {
struct {
u64 status;
@@ -78,7 +83,7 @@ struct ps3_bmp {
*/
struct ps3_private {
- struct ps3_bmp bmp __attribute__ ((aligned (64)));
+ struct ps3_bmp bmp __attribute__ ((aligned (PS3_BMP_MINALIGN)));
u64 node;
unsigned int cpu;
};