aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Glöckner <dg@emlix.com>2009-06-11 14:36:29 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2009-06-11 08:51:08 -0700
commit26bbb3ff1ff6163d6a233055766e26af8054a212 (patch)
treeba50f720a04c0fd3a34bb8a29c362d24c8585b03
parentd3810cd4d7064b109574374f73c41b11b481dbf2 (diff)
imx: serial: fix one bit field type
"have_rtscts" is assigned 1, while it is declared int:1, two's complement, which can hold 0 and -1 only. The code works, as the upper bits are cut off, and tests are done against 0 only. Nonetheless, correctly declaring the bit field as unsigned int:1 renders the code more robust. Signed-off-by: Daniel Glöckner <dg@emlix.com> Signed-off-by: Oskar Schirmer <os@emlix.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/serial/imx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/serial/imx.c b/drivers/serial/imx.c
index 76c8fa1884e..6b8f12f4a70 100644
--- a/drivers/serial/imx.c
+++ b/drivers/serial/imx.c
@@ -211,7 +211,7 @@ struct imx_port {
struct timer_list timer;
unsigned int old_status;
int txirq,rxirq,rtsirq;
- int have_rtscts:1;
+ unsigned int have_rtscts:1;
struct clk *clk;
};