diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2006-01-10 00:09:16 +0300 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-01-09 13:02:51 -0800 |
| commit | 682e852e2638ed0aff84aa51181c9e5d2f939562 (patch) | |
| tree | e1a5221fe0c98d743fbceec2d0932f3556aecf93 | |
| parent | 41ed16fa47350661da01443b8241bf6ca8080fd7 (diff) | |
[PATCH] Fix more "if ((err = foo() < 0))" typos
Another reason to use:
ret = foo();
if (ret < 0)
goto out;
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | Documentation/kprobes.txt | 3 | ||||
| -rw-r--r-- | arch/mips/kernel/vpe.c | 3 | ||||
| -rw-r--r-- | drivers/media/dvb/frontends/mt312.c | 3 |
3 files changed, 6 insertions, 3 deletions
diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt index 0541fe1de70..0ea5a0c6e82 100644 --- a/Documentation/kprobes.txt +++ b/Documentation/kprobes.txt @@ -411,7 +411,8 @@ int init_module(void) printk("Couldn't find %s to plant kprobe\n", "do_fork"); return -1; } - if ((ret = register_kprobe(&kp) < 0)) { + ret = register_kprobe(&kp); + if (ret < 0) { printk("register_kprobe failed, returned %d\n", ret); return -1; } diff --git a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c index 06be405be39..9c89eebc356 100644 --- a/arch/mips/kernel/vpe.c +++ b/arch/mips/kernel/vpe.c @@ -1171,7 +1171,8 @@ static int __init vpe_module_init(void) return -ENODEV; } - if ((major = register_chrdev(0, module_name, &vpe_fops) < 0)) { + major = register_chrdev(0, module_name, &vpe_fops); + if (major < 0) { printk("VPE loader: unable to register character device\n"); return major; } diff --git a/drivers/media/dvb/frontends/mt312.c b/drivers/media/dvb/frontends/mt312.c index 8d672283c93..ec4e641acc6 100644 --- a/drivers/media/dvb/frontends/mt312.c +++ b/drivers/media/dvb/frontends/mt312.c @@ -501,7 +501,8 @@ static int mt312_set_frontend(struct dvb_frontend* fe, case ID_VP310: // For now we will do this only for the VP310. // It should be better for the mt312 as well, but tunning will be slower. ACCJr 09/29/03 - if ((ret = mt312_readreg(state, CONFIG, &config_val) < 0)) + ret = mt312_readreg(state, CONFIG, &config_val); + if (ret < 0) return ret; if (p->u.qpsk.symbol_rate >= 30000000) //Note that 30MS/s should use 90MHz { |