aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@suse.de>2009-09-01 20:12:58 -0700
committerGreg Kroah-Hartman <gregkh@suse.de>2009-09-15 12:02:02 -0700
commit689bf406829c8a5e44ebf8fc8918b77b3806ee48 (patch)
tree6afec7c8b003a8f581826f7ce400dd1ac26d69a6
parentf4266e342527b4309119edde777bb9fbb4e0ef33 (diff)
Staging: hv: warn the world of a bug in the release function
All device release functions need to do something, if not, it's a bug. By merely providing an "empty" release function, it gets the kernel to shut up, but that's not solving the problem at all. Stick a big fat WARN_ON(1); in there to get people's attention. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/staging/hv/vmbus_drv.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
index 4462d5bb87e..cc81ffd7e8a 100644
--- a/drivers/staging/hv/vmbus_drv.c
+++ b/drivers/staging/hv/vmbus_drv.c
@@ -965,6 +965,11 @@ Desc: Final callback release of the vmbus root device
static void vmbus_bus_release(struct device *device)
{
DPRINT_ENTER(VMBUS_DRV);
+ /* FIXME */
+ /* Empty release functions are a bug, or a major sign
+ * of a problem design, this MUST BE FIXED! */
+ dev_err(device, "%s needs to be fixed!\n", __func__);
+ WARN_ON(1);
DPRINT_EXIT(VMBUS_DRV);
}