diff options
author | Steve Glendinning <steve.glendinning@smsc.com> | 2009-03-04 07:33:25 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-03-13 12:14:11 -0700 |
commit | f7efb6ccc2113911e4e064f78bcd0343c4673038 (patch) | |
tree | 3856f2a8ffa3ac0efc6da507b194f93183b2b0d6 /arch/sparc/prom | |
parent | 8dacd548129d03e87751f75ea83b42a8a17ee651 (diff) |
smsc911x: improve EEPROM loading timeout logic in open
This patch from Juha Leppanen suppresses a false warning if the eeprom
load succeeds on the very last attempt.
Juha> In function smsc911x_open smsc911x_reg_read+udelay can be run 50
Juha> times with timeout reaching -1, and the following if statetement
Juha> does not catch the timeout and no warning is issued. Also if the
Juha> 50th smsc911x_reg_read is GOOD, loop is exited with timeout as 0
Juha> and bogus warning issued. Replace testing order and --timeout
Juha> instead of timeout-- and now max 50 smsc911x_reg_read's are done,
Juha> with max 49 udelays.
Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc/prom')
0 files changed, 0 insertions, 0 deletions