diff options
author | Pablo Neira Ayuso <pablo@netfilter.org> | 2009-03-03 23:37:30 -0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-03-03 23:37:30 -0800 |
commit | 4843b93c96ae5043c6279c4ec6fcd8ee3866ff5b (patch) | |
tree | 58532635d403fba5b1514dfbf2c707f93b5ba1ed /drivers/ide/umc8672.c | |
parent | 17edde520927070a6bf14a6a75027c0b843443e5 (diff) |
netlink: invert error code in netlink_set_err()
The callers of netlink_set_err() currently pass a negative value
as parameter for the error code. However, sk->sk_err wants a
positive error value. Without this patch, skb_recv_datagram() called
by netlink_recvmsg() may return a positive value to report an error.
Another choice to fix this is to change callers to pass a positive
error value, but this seems a bit inconsistent and error prone
to me. Indeed, the callers of netlink_set_err() assumed that the
(usual) negative value for error codes was fine before this patch :).
This patch also includes some documentation in docbook format
for netlink_set_err() to avoid this sort of confusion.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ide/umc8672.c')
0 files changed, 0 insertions, 0 deletions