diff options
author | Paul Mundt <lethal@linux-sh.org> | 2009-11-04 15:59:04 +0900 |
---|---|---|
committer | Paul Mundt <lethal@linux-sh.org> | 2009-11-04 15:59:04 +0900 |
commit | 5c1a56b5f616f7063f91eb85f0ea209658f387dc (patch) | |
tree | 227964f2cbde7986538836e153da33879ed4822d /drivers/misc | |
parent | 9016332014404ae1dca7198f93804ac67ba9e918 (diff) |
video: sh_mobile_lcdcfb: Don't attempt to map zero-length scatterlists.
More aggressive DMA mapping debugging has uncovered a long-standing
buglet in the way that the sh_mobile_lcdcfb driver implements its
deferred I/O callback. When used as a console driver the acceleration
routines are called by the kernel which subsequently cause the deferred
I/O work to be scheduled, resulting in the deferred I/O callback being
entered without any dirty pages on the pagelist (the normal case for
userspace accesses). It's also possible to get in to this situation via
explicit calling of fsync() when nothing has dirtied the region.
Unfortunately it's not sufficient to skip over the callback when the
pagelist is empty given the console driver use case, so instead the
callback has to conditionalize the work for panel updates and DMA
mapping depending on whether anything is resident on the pagelist or
not.
Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Diffstat (limited to 'drivers/misc')
0 files changed, 0 insertions, 0 deletions