aboutsummaryrefslogtreecommitdiff
path: root/drivers/nubus
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2008-12-25 13:39:28 +0100
committerMartin Schwidefsky <schwidefsky@de.ibm.com>2008-12-25 13:39:16 +0100
commit21e7b2c4d59e5d6631b25e71e777cb0160997d6a (patch)
treeb7ec97726e6d16756da6104f5284ea98453c8f80 /drivers/nubus
parent33b1d09ef317d64c58b135c2e811bb55b3f15b19 (diff)
[S390] drivers/s390/crypto: Move dereference to after IS_ERR test
If reply is ERR_PTR(...), then it should not be dereferenced, so I have moved the dereference from the declaration to after the IS_ERR test. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @match exists@ expression x, E; identifier fld; position p1,p2; @@ ( x = E; | x = E | x@p1->fld ... when != x = E IS_ERR(x@p2) ... when any ) @other_match exists@ expression match.x, E1, E2; position match.p1,match.p2; @@ x = E1 ... when != x = E2 when != x@p1 x@p2 @ script:python depends on !other_match@ p1 << match.p1; p2 << match.p2; @@ print "* file %s dereference %s test %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/nubus')
0 files changed, 0 insertions, 0 deletions