aboutsummaryrefslogtreecommitdiff
path: root/drivers/video
diff options
context:
space:
mode:
authorRoland Dreier <rolandd@cisco.com>2008-11-28 21:55:42 -0800
committerDavid S. Miller <davem@davemloft.net>2008-11-28 21:55:42 -0800
commitc5419e6f054c877339f754e02c3b1dafd88cd96c (patch)
tree23f31f5387304a49dc768b503356671523611c86 /drivers/video
parentf95be1806fde884c1655237d49a7e5f82e4a935f (diff)
cxgb3: Fix sparse warning and micro-optimize is_pure_response()
The function is_pure_response() does "ntohl(var) & const" and then essentially just tests whether the result is 0 or not; this can be done more efficiently by computing "var & htonl(const)" instead and doing the byte swap at compile time instead of run time. This change slightly shrinks the compiled code; eg on x86-64 we save a couple of bswapl instructions: add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-8 (-8) function old new delta t3_sge_intr_msix_napi 544 536 -8 and this also has the pleasant side effect of fixing a sparse warning: drivers/net/cxgb3/sge.c:2313:15: warning: restricted degrades to integer Signed-off-by: Roland Dreier <rolandd@cisco.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/video')
0 files changed, 0 insertions, 0 deletions