diff options
author | Miklos Szeredi <mszeredi@suse.cz> | 2007-10-16 23:27:08 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 08:42:52 -0700 |
commit | 22590e41cb569add194829c08dc0ceea74b38a65 (patch) | |
tree | 0db73fe0e78bcde816dcf289e0aa5323abf73833 /fs/sysfs/symlink.c | |
parent | 043f46f6151df2c518988b5e41376e42491257b5 (diff) |
fix execute checking in permission()
permission() checks that MAY_EXEC is only allowed on regular files if at least
one execute bit is set in the file mode.
generic_permission() already ensures this, so the extra check in permission()
is superfluous.
If the filesystem defines it's own ->permission() the check may still be
needed. In this case move it after ->permission(). This is needed because
filesystems such as FUSE may need to refresh the inode attributes before
checking permissions.
This check should be moved inside ->permission(), but that's another story.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/sysfs/symlink.c')
0 files changed, 0 insertions, 0 deletions