aboutsummaryrefslogtreecommitdiff
path: root/fs/xfs/xfs_dinode.h
diff options
context:
space:
mode:
authorJeff Layton <jlayton@redhat.com>2008-10-16 18:46:39 +0000
committerSteve French <sfrench@us.ibm.com>2008-10-16 18:46:39 +0000
commit469ee614aaa367d9cde01cbdd2027212f56c6cc6 (patch)
treeb3adf11b97e14ece7c10c81ea9f156f16491ca87 /fs/xfs/xfs_dinode.h
parent2c1b861539c15491593625920058e06452cd3747 (diff)
[CIFS] eliminate usage of kthread_stop for cifsd
When cifs_demultiplex_thread was converted to a kthread based kernel thread, great pains were taken to make it so that kthread_stop would be used to bring it down. This just added unnecessary complexity since we needed to use a signal anyway to break out of kernel_recvmsg. Also, cifs_demultiplex_thread does a bit of cleanup as it's exiting, and we need to be certain that this gets done. It's possible for a kthread to exit before its main function is ever run if kthread_stop is called soon after its creation. While I'm not sure that this is a real problem with cifsd now, it could be at some point in the future if cifs_mount is ever changed to bring down the thread quickly. The upshot here is that using kthread_stop to bring down the thread just adds extra complexity with no real benefit. This patch changes the code to use the original method to bring down the thread, but still leaves it so that the thread is actually started with kthread_run. This seems to fix the deadlock caused by the reproducer in this bug report: https://bugzilla.samba.org/show_bug.cgi?id=5720 Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/xfs/xfs_dinode.h')
0 files changed, 0 insertions, 0 deletions