diff options
author | Jiri Olsa <jolsa@redhat.com> | 2009-10-23 19:36:17 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-10-24 11:07:50 +0200 |
commit | 3e69533b51930a7169235db2caf703884e6e3bbb (patch) | |
tree | 4cd0fe383dcb9eab2b0f944f227caffa3cdcd209 /kernel/sysctl.c | |
parent | cf8517cf905b5cd31d5790250b9ac39f7cb8aa53 (diff) |
tracing: Fix trace_seq_printf() return value
trace_seq_printf() return value is a little ambiguous. It
currently returns the length of the space available in the
buffer. printf usually returns the amount written. This is not
adequate here, because:
trace_seq_printf(s, "");
is perfectly legal, and returning 0 would indicate that it
failed.
We can always see the amount written by looking at the before
and after values of s->len. This is not quite the same use as
printf. We only care if the string was successfully written to
the buffer or not.
Make trace_seq_printf() return 0 if the trace oversizes the
buffer's free space, 1 otherwise.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <20091023233646.631787612@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sysctl.c')
0 files changed, 0 insertions, 0 deletions