diff options
author | John W. Linville <linville@tuxdriver.com> | 2008-10-31 14:13:12 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2008-11-21 11:06:02 -0500 |
commit | 3d29b0c33d431ecc69ec778f8c236d382f59a85f (patch) | |
tree | b11d062b298f72d76234259bc54e925439b5c2cf /lib/crc16.c | |
parent | 9d2f4720971c00852a3fc8278a76f1a5e9add5c7 (diff) |
netdevice zd1201: Convert directly reference of netdev->priv to netdev_priv()
We have some reasons to kill netdev->priv:
1. netdev->priv is equal to netdev_priv().
2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
netdev_priv() is more flexible than netdev->priv.
But we cann't kill netdev->priv, because so many drivers reference to it
directly.
OK, becasue Dave S. Miller said, "every direct netdev->priv usage is a bug",
and I want to kill netdev->priv later, I decided to convert all the direct
reference of netdev->priv first.
(Original patch posted by Wang Chen <wangchen@cn.fujitsu.com> w/ above
changelog but using dev->ml_priv. That doesn't seem appropriate
to me for this driver, so I've revamped it to use netdev_priv()
instead. -- JWL)
Reviewed-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'lib/crc16.c')
0 files changed, 0 insertions, 0 deletions