diff options
author | Pavel Emelyanov <xemul@openvz.org> | 2008-11-14 14:51:45 -0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-11-14 14:51:45 -0800 |
commit | 5421ae0153b4ba0469967cfd8de96144e3bf3979 (patch) | |
tree | 99a47894d513e8726cc96b5eff26b16adfc619b9 /net/8021q | |
parent | d8c3e23d06c1020f38b7b6290135a9522a2e3052 (diff) |
scm: fix scm_fp_list->list initialization made in wrong place
This is the next page of the scm recursion story (the commit
f8d570a4 net: Fix recursive descent in __scm_destroy()).
In function scm_fp_dup(), the INIT_LIST_HEAD(&fpl->list) of newly
created fpl is done *before* the subsequent memcpy from the old
structure and thus the freshly initialized list is overwritten.
But that's OK, since this initialization is not required at all,
since the fpl->list is list_add-ed at the destruction time in any
case (and is unused in other code), so I propose to drop both
initializations, rather than moving it after the memcpy.
Please, correct me if I miss something significant.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q')
0 files changed, 0 insertions, 0 deletions