diff options
| author | Denis V. Lunev <den@openvz.org> | 2008-01-14 22:59:30 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-01-28 15:02:09 -0800 |
| commit | 72132c1b6c7a7605cdfde86a9f58b6ca2b2195a6 (patch) | |
| tree | 35b13af8135ad136800f39b9a7aff40082123878 /net/core | |
| parent | 2db82b534bd52b349f1b2ab3e63aa40ca0e466ab (diff) | |
[IPV4]: fib_rules_unregister is essentially void.
fib_rules_unregister is called only after successful register and the
return code is never checked.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/fib_rules.c | 21 |
1 files changed, 4 insertions, 17 deletions
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c index c5f78fed688..541728aa2ba 100644 --- a/net/core/fib_rules.c +++ b/net/core/fib_rules.c @@ -112,29 +112,16 @@ void fib_rules_cleanup_ops(struct fib_rules_ops *ops) } EXPORT_SYMBOL_GPL(fib_rules_cleanup_ops); -int fib_rules_unregister(struct net *net, struct fib_rules_ops *ops) +void fib_rules_unregister(struct net *net, struct fib_rules_ops *ops) { - int err = 0; - struct fib_rules_ops *o; spin_lock(&net->rules_mod_lock); - list_for_each_entry(o, &net->rules_ops, list) { - if (o == ops) { - list_del_rcu(&o->list); - fib_rules_cleanup_ops(ops); - goto out; - } - } - - err = -ENOENT; -out: + list_del_rcu(&ops->list); + fib_rules_cleanup_ops(ops); spin_unlock(&net->rules_mod_lock); synchronize_rcu(); - if (!err) - release_net(net); - - return err; + release_net(net); } EXPORT_SYMBOL_GPL(fib_rules_unregister); |