diff options
author | Linus Torvalds <torvalds@g5.osdl.org> | 2006-11-04 10:06:02 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-11-04 10:06:02 -0800 |
commit | 45c18b0bb579b5c1b89f8c99f1b6ffa4c586ba08 (patch) | |
tree | 2dbd334c763232ce2de46739908054639e5629c8 /net/ipx/ipx_proc.c | |
parent | 80491eb90c750fcd7d13830062f27ae9b7cc5f75 (diff) |
Fix unlikely (but possible) race condition on task->user access
There's a possible race condition when doing a "switch_uid()" from one
user to another, which could race with another thread doing a signal
allocation and looking at the old thread ->user pointer as it is freed.
This explains an oops reported by Lukasz Trabinski:
http://permalink.gmane.org/gmane.linux.kernel/462241
We fix this by delaying the (reference-counted) freeing of the user
structure until the thread signal handler lock has been released, so
that we know that the signal allocation has either seen the new value or
has properly incremented the reference count of the old one.
Race identified by Oleg Nesterov.
Cc: Lukasz Trabinski <lukasz@wsisiz.edu.pl>
Cc: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@osdl.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'net/ipx/ipx_proc.c')
0 files changed, 0 insertions, 0 deletions