From 0a920b5b666d0be8141bd1ce620fffa7de96b81b Mon Sep 17 00:00:00 2001 From: Andy Whitcroft Date: Fri, 1 Jun 2007 00:46:48 -0700 Subject: add a trivial patch style checker We are seeing increasing levels of minor patch style violations in submissions to the mailing lists as well as making it into the tree. These detract from the quality of the submission and cause unnessary work for reviewers. As a first step package up the current state of the patch style checker and include it in the kernel tree. Add instructions suggesting running it on submissions. This adds version v0.01 of the checkpatch.pl script. Signed-off-by: Andy Whitcroft Signed-off-by: Joel Schopp Cc: Randy Dunlap Cc: Dave Jones Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- Documentation/SubmitChecklist | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'Documentation/SubmitChecklist') diff --git a/Documentation/SubmitChecklist b/Documentation/SubmitChecklist index 3af3e65cf43..6ebffb57e3d 100644 --- a/Documentation/SubmitChecklist +++ b/Documentation/SubmitChecklist @@ -84,3 +84,9 @@ kernel patches. 24: Avoid whitespace damage such as indenting with spaces or whitespace at the end of lines. You can test this by feeding the patch to "git apply --check --whitespace=error-all" + +25: Check your patch for general style as detailed in + Documentation/CodingStyle. Check for trivial violations with the + patch style checker prior to submission (scripts/checkpatch.pl). + You should be able to justify all violations that remain in + your patch. -- cgit v1.2.3