From 9e58a18567ec1ef306ea7b973749e5cd9902702c Mon Sep 17 00:00:00 2001 From: Nelson Castillo Date: Tue, 10 Mar 2009 12:04:16 +0000 Subject: Use non-void configurations This patch defines a ts_filter_configuration structure to avoid using void* in the filter initialization, fixing another upstream correction. This also makes the initialization more readable. Tested in GTA02/rev6. Other changes: ~ Comment filter configuration structures. ~ ts_filter.c:ts_filter_chain_create improved. ~ Small cleanups. ~ More TODOs/FIXMEs. ~ Updated GTA02 filter configuration. ~ Updated GTA01 filter configuration. ~ Updated mach-s3c2410/include/mach/ts.h for the new ts. configuration structure. ~ Updated all the filters to use the new configuration structure. ~ Removed MAX_TS_FILTER_CHAIN constant that is no longer needed. No more evil casts left it seems. Signed-off-by: Nelson Castillo --- drivers/input/touchscreen/ts_filter_linear.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'drivers/input/touchscreen/ts_filter_linear.h') diff --git a/drivers/input/touchscreen/ts_filter_linear.h b/drivers/input/touchscreen/ts_filter_linear.h index 9da5b82881c..5cd9a81158d 100644 --- a/drivers/input/touchscreen/ts_filter_linear.h +++ b/drivers/input/touchscreen/ts_filter_linear.h @@ -14,13 +14,16 @@ #define TS_FILTER_LINEAR_NCONSTANTS 7 -/* filter configuration */ - -/* FIXME: comment every field. */ struct ts_filter_linear_configuration { + /* Calibration constants. */ int constants[TS_FILTER_LINEAR_NCONSTANTS]; + /* First coordinate. */ int coord0; + /* Second coordinate. */ int coord1; + + /* Generic filter configuration. */ + struct ts_filter_configuration config; }; extern struct ts_filter_api ts_filter_linear_api; -- cgit v1.2.3