diff options
author | Thomas White <taw@physics.org> | 2019-07-29 16:00:10 +0200 |
---|---|---|
committer | Thomas White <taw@physics.org> | 2019-07-29 17:11:16 +0200 |
commit | 82719e4d6fec3c28bcdc310ba382e12aa4f041d4 (patch) | |
tree | d518bcdc0649ac9bb07747619c5dc751744ce72d /src/geoptimiser.c | |
parent | 83ef79e1642841966690e4c9643a8716e8521112 (diff) |
Re-implement copy_geom()
The old version assumed that the rigid groups appeared in the new
list in the same order as the old one. Note the use of subscript "i"
for both arrays here:
if ( rigid_group_is_in_collection(
in->rigid_group_collections[rgci],
in->rigid_groups[i]) )
[....]
add_to_rigid_group_coll(rgcoll,
out->rigid_groups[i]);
However, the new list of rigid groups, out->rigid_groups, was
constructed not by copying the old list (in->rigid_groups), but rather
by iterating over the panels and adding the groups as they were
encountered. Therefore, the assumption of same ordering was invalid,
and the new rigid group collection incorrect.
Diffstat (limited to 'src/geoptimiser.c')
0 files changed, 0 insertions, 0 deletions