diff options
author | Mikael Pettersson <mikpe@it.uu.se> | 2008-10-31 08:03:55 +0100 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-11-04 01:08:03 -0500 |
commit | cadef677e4a9b9c1d069675043767df486782986 (patch) | |
tree | 054bd2b2f71af931c8692ff210a04bbe91450b2d /.mailmap | |
parent | a75952b72a0fff3031124003e62118111aed42c1 (diff) |
sata_promise: add ATA engine reset to reset ops
Promise ATA engines need to be reset when errors occur.
That's currently done for errors detected by sata_promise itself,
but it's not done for errors like timeouts detected outside of
the low-level driver.
The effect of this omission is that a timeout tends to result
in a sequence of failed COMRESETs after which libata EH gives
up and disables the port. At that point the port's ATA engine
hangs and even reloading the driver will not resume it.
To fix this, make sata_promise override ->hardreset on SATA
ports with code which calls pdc_reset_port() on the port in
question before calling libata's hardreset. PATA ports don't
use ->hardreset, so for those we override ->softreset instead.
Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions