diff options
| author | Jens Rottmann <JRottmann@LiPPERTEmbedded.de> | 2010-03-23 04:23:50 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-03-23 13:06:15 -0700 |
| commit | 4881a4f89a95cc5fef6d32953954bcc3443eefd5 (patch) | |
| tree | 7bbbf2c6e43538f7cb9cfbe8943d4ea02381ca46 | |
| parent | 8e039d84b323c4503c4d56863faa47c783660826 (diff) | |
ksz884x: fix return value of netdev_set_eeprom
ksz884x: fix return value of netdev_set_eeprom
netdev_set_eeprom() confused ethtool by just returning 1 on error
instead of a proper -EINVAL.
Signed-off-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ksz884x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c index 0f59099ee72..6c5327af1bf 100644 --- a/drivers/net/ksz884x.c +++ b/drivers/net/ksz884x.c @@ -6322,7 +6322,7 @@ static int netdev_set_eeprom(struct net_device *dev, int len; if (eeprom->magic != EEPROM_MAGIC) - return 1; + return -EINVAL; len = (eeprom->offset + eeprom->len + 1) / 2; for (i = eeprom->offset / 2; i < len; i++) |