aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@g5.osdl.org>2006-01-10 08:56:39 -0800
committerLinus Torvalds <torvalds@g5.osdl.org>2006-01-10 08:56:39 -0800
commit4f47707b056bd2e3627ef390557ee93d312daba5 (patch)
tree3d3b7f1a4e43e4b077bf9388e0ec2bb11eeb2daa
parenta9c828155ae8d1a1576f9648cc4d9677aea53f89 (diff)
Fix rpc shutdown event condition bug
We want to wait for the cl_users to go down to zero, not for it to stay positive. Quoth Trond (who wasn't even the author, but acked the wrong version): "Argh! I need to increase my daily caffeine dosages." Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--net/sunrpc/clnt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index a44da8b3d24..4cef7fa2b74 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -269,7 +269,7 @@ rpc_shutdown_client(struct rpc_clnt *clnt)
clnt->cl_dead = 0;
rpc_killall_tasks(clnt);
wait_event_timeout(destroy_wait,
- atomic_read(&clnt->cl_users) > 0, 1*HZ);
+ !atomic_read(&clnt->cl_users), 1*HZ);
}
if (atomic_read(&clnt->cl_users) < 0) {