aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorakpm@osdl.org <akpm@osdl.org>2005-04-16 15:24:00 -0700
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-04-16 15:24:00 -0700
commite493073d8d053429fbb42331b57a95dd0d61cadb (patch)
treec4d697372f6c2f2e2f2548f75c1dbb5b821ab805
parent81ddef77bb774e771db8588b937665cd38f40cee (diff)
[PATCH] Fix acl Oops
) From: Andreas Gruenbacher <agruen@suse.de> ext[23]_get_acl will return an error when reading the attribute fails or out-of-memory occurs. Catch this case. Signed-off-by: Andreas Gruenbacher <agruen@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--fs/ext2/acl.c2
-rw-r--r--fs/ext3/acl.c2
2 files changed, 4 insertions, 0 deletions
diff --git a/fs/ext2/acl.c b/fs/ext2/acl.c
index 8369ee8d28c..25f4a64fd6b 100644
--- a/fs/ext2/acl.c
+++ b/fs/ext2/acl.c
@@ -283,6 +283,8 @@ ext2_check_acl(struct inode *inode, int mask)
{
struct posix_acl *acl = ext2_get_acl(inode, ACL_TYPE_ACCESS);
+ if (IS_ERR(acl))
+ return PTR_ERR(acl);
if (acl) {
int error = posix_acl_permission(inode, acl, mask);
posix_acl_release(acl);
diff --git a/fs/ext3/acl.c b/fs/ext3/acl.c
index 328592c3a95..638c13a26c0 100644
--- a/fs/ext3/acl.c
+++ b/fs/ext3/acl.c
@@ -286,6 +286,8 @@ ext3_check_acl(struct inode *inode, int mask)
{
struct posix_acl *acl = ext3_get_acl(inode, ACL_TYPE_ACCESS);
+ if (IS_ERR(acl))
+ return PTR_ERR(acl);
if (acl) {
int error = posix_acl_permission(inode, acl, mask);
posix_acl_release(acl);