aboutsummaryrefslogtreecommitdiff
path: root/drivers/md
diff options
context:
space:
mode:
authorMilan Broz <mbroz@redhat.com>2008-02-08 02:10:25 +0000
committerAlasdair G Kergon <agk@redhat.com>2008-02-08 02:10:25 +0000
commit73d410c0137f63c6597e9763c81e5f4d015e9940 (patch)
treed76251d96254217b6935dee0acca676476a7a45e /drivers/md
parent6d6f10df890df8be69edd4db32dc8ce09f311bb8 (diff)
dm: tidy dm_suspend
Tidy dm_suspend function - change return value logic in dm_suspend - use atomic_read only once. - move DMF_BLOCK_IO clearing into one place Signed-off-by: Milan Broz <mbroz@redhat.com> Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Diffstat (limited to 'drivers/md')
-rw-r--r--drivers/md/dm.c21
1 files changed, 11 insertions, 10 deletions
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index c1ad7d77dbc..5191954a18b 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -1270,6 +1270,8 @@ static void __flush_deferred_io(struct mapped_device *md)
if (__split_bio(md, c))
bio_io_error(c);
}
+
+ clear_bit(DMF_BLOCK_IO, &md->flags);
}
static void __merge_pushback_list(struct mapped_device *md)
@@ -1355,14 +1357,16 @@ int dm_suspend(struct mapped_device *md, unsigned suspend_flags)
{
struct dm_table *map = NULL;
DECLARE_WAITQUEUE(wait, current);
- int r = -EINVAL;
+ int pending, r = 0;
int do_lockfs = suspend_flags & DM_SUSPEND_LOCKFS_FLAG ? 1 : 0;
int noflush = suspend_flags & DM_SUSPEND_NOFLUSH_FLAG ? 1 : 0;
mutex_lock(&md->suspend_lock);
- if (dm_suspended(md))
+ if (dm_suspended(md)) {
+ r = -EINVAL;
goto out_unlock;
+ }
map = dm_get_table(md);
@@ -1417,7 +1421,8 @@ int dm_suspend(struct mapped_device *md, unsigned suspend_flags)
set_current_state(TASK_INTERRUPTIBLE);
smp_mb();
- if (!atomic_read(&md->pending) || signal_pending(current))
+ pending = atomic_read(&md->pending);
+ if (!pending || signal_pending(current))
break;
io_schedule();
@@ -1431,12 +1436,12 @@ int dm_suspend(struct mapped_device *md, unsigned suspend_flags)
__merge_pushback_list(md);
/* were we interrupted ? */
- r = -EINTR;
- if (atomic_read(&md->pending)) {
- clear_bit(DMF_BLOCK_IO, &md->flags);
+ if (pending) {
__flush_deferred_io(md);
up_write(&md->io_lock);
+
unlock_fs(md);
+ r = -EINTR;
goto out; /* pushback list is already flushed, so skip flush */
}
up_write(&md->io_lock);
@@ -1445,8 +1450,6 @@ int dm_suspend(struct mapped_device *md, unsigned suspend_flags)
set_bit(DMF_SUSPENDED, &md->flags);
- r = 0;
-
flush_and_out:
if (r && noflush) {
/*
@@ -1490,8 +1493,6 @@ int dm_resume(struct mapped_device *md)
goto out;
down_write(&md->io_lock);
- clear_bit(DMF_BLOCK_IO, &md->flags);
-
__flush_deferred_io(md);
up_write(&md->io_lock);