aboutsummaryrefslogtreecommitdiff
path: root/drivers/usb
diff options
context:
space:
mode:
authorAndy Green <andy@openmoko.com>2008-11-19 17:11:11 +0000
committerAndy Green <agreen@pads.home.warmcat.com>2008-11-19 17:11:11 +0000
commitffd971f33de90a3c6385eb666f23869aa3ae9686 (patch)
treefd67df6dee093fef00d81cf260f061bd20d861b1 /drivers/usb
parent8d61a6755fd89b24b126f81f53c145915830404a (diff)
fix-s3c2410-usb-controller-mode-change-always-EINVAL.patch
We always return -EINVAL when changing s3c2410 USB host and device modes due to lack of { }. Signed-off-by: Andy Green <andy@openmoko.com>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/host/ohci-s3c2410.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/host/ohci-s3c2410.c b/drivers/usb/host/ohci-s3c2410.c
index 717b6951fda..98610b29c65 100644
--- a/drivers/usb/host/ohci-s3c2410.c
+++ b/drivers/usb/host/ohci-s3c2410.c
@@ -335,9 +335,11 @@ static ssize_t set_usb_mode(struct device *dev, struct device_attribute *attr,
printk("s3c2410: changing usb to device\n");
s3c2410_modify_misccr(S3C2410_MISCCR_USBHOST, 0);
s3c2410_gpio_setpin(S3C2410_GPB9, 1);
- } else
+ } else {
printk("s3c2410: unknown mode\n");
return -EINVAL;
+ }
+
return count;
}