aboutsummaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@g5.osdl.org>2005-07-06 13:05:50 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2005-07-06 13:05:50 -0700
commit07bbeaf12310263d808b1958f8413b95f98786ea (patch)
tree5a739fb75f8e14b8c5f2274d8f1efa6fed145b34 /drivers
parent184f6eb8c46afc2a4aa6cb7c51ebc423c36d9c9d (diff)
ieee1394: fix broken signed char assumption.
"ack_code" is assigned (and tested against) negative numbers, but was declared as "char". Which only works if "char" is signed - which it necessarily isn't. So make that signedness assumption specific.
Diffstat (limited to 'drivers')
-rw-r--r--drivers/ieee1394/ieee1394_core.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ieee1394/ieee1394_core.h b/drivers/ieee1394/ieee1394_core.h
index 73bd8efd2b6..0b31429d0a6 100644
--- a/drivers/ieee1394/ieee1394_core.h
+++ b/drivers/ieee1394/ieee1394_core.h
@@ -38,8 +38,8 @@ struct hpsb_packet {
/* These are core internal. */
signed char tlabel;
- char ack_code;
- char tcode;
+ signed char ack_code;
+ unsigned char tcode;
unsigned expect_response:1;
unsigned no_waiter:1;