pcf50633_rtc.patch

Move the RTC subdevice driver into drivers/rtc/rtc-pcf50633.c

4 files changed, 293 insertions, 242 deletions

diff --git a/drivers/i2c/chips/pcf50633.c b/drivers/i2c/chips/pcf50633.c
index 419dd3198f7..8ba414bc531 100644
--- a/drivers/i2c/chips/pcf50633.c
+++ b/drivers/i2c/chips/pcf50633.c
@@ -22,7 +22,6 @@
  * This driver is a monster ;) It provides the following features
  * - voltage control for a dozen different voltage domains
  * - charging control for main and backup battery
- * - rtc / alarm
  * - adc driver (hw_sensors like)
  *
  */
@@ -51,6 +50,7 @@
 
 #include <linux/pcf50633.h>
 #include <linux/regulator/pcf50633.h>
+#include <linux/rtc/pcf50633.h>
 
 #if 0
 #define DEBUGP(x, args ...) printk("%s: " x, __FUNCTION__, ## args)
@@ -68,27 +68,6 @@ static unsigned short normal_i2c[] = { 0x73, I2C_CLIENT_END };
 
 I2C_CLIENT_INSMOD_1(pcf50633);
 
-#define PCF50633_FIDX_CHG_ENABLED	0	/* Charger enabled */
-#define PCF50633_FIDX_CHG_PRESENT	1	/* Charger present */
-#define PCF50633_FIDX_CHG_ERR		3	/* Charger Error */
-#define PCF50633_FIDX_CHG_PROT		4	/* Charger Protection */
-#define PCF50633_FIDX_CHG_READY		5	/* Charging completed */
-#define PCF50633_FIDX_PWR_PRESSED	8
-#define PCF50633_FIDX_RTC_SECOND	9
-#define PCF50633_FIDX_USB_PRESENT	10
-
-#define PCF50633_F_CHG_ENABLED	(1 << PCF50633_FIDX_CHG_ENABLED)
-#define PCF50633_F_CHG_PRESENT	(1 << PCF50633_FIDX_CHG_PRESENT)
-#define PCF50633_F_CHG_ERR	(1 << PCF50633_FIDX_CHG_ERR)
-#define PCF50633_F_CHG_PROT	(1 << PCF50633_FIDX_CHG_PROT)
-#define PCF50633_F_CHG_READY	(1 << PCF50633_FIDX_CHG_READY)
-
-#define PCF50633_F_CHG_MASK	0x000000fc
-
-#define PCF50633_F_PWR_PRESSED	(1 << PCF50633_FIDX_PWR_PRESSED)
-#define PCF50633_F_RTC_SECOND	(1 << PCF50633_FIDX_RTC_SECOND)
-#define PCF50633_F_USB_PRESENT	(1 << PCF50633_FIDX_USB_PRESENT)
-
 enum close_state {
 	CLOSE_STATE_NOT,
 	CLOSE_STATE_ALLOW = 0x2342,
@@ -753,12 +732,14 @@ static void pcf50633_work(struct work_struct *work)
 	if (pcfirq[0] & PCF50633_INT1_ALARM) {
 		DEBUGPC("ALARM ");
 		if (pcf->pdata->used_features & PCF50633_FEAT_RTC)
-			rtc_update_irq(pcf->rtc, 1, RTC_AF | RTC_IRQF);
+			pcf50633_rtc_handle_event(pcf,
+					PCF50633_RTC_EVENT_ALARM);
 	}
 	if (pcfirq[0] & PCF50633_INT1_SECOND) {
 		DEBUGPC("SECOND ");
 		if (pcf->flags & PCF50633_F_RTC_SECOND)
-			rtc_update_irq(pcf->rtc, 1, RTC_PF | RTC_IRQF);
+			pcf50633_rtc_handle_event(pcf,
+					PCF50633_RTC_EVENT_SECOND);
 
 		if (pcf->onkey_seconds >= 0 &&
 		    pcf->flags & PCF50633_F_PWR_PRESSED) {
@@ -1330,219 +1311,6 @@ static ssize_t show_chgstate(struct device *dev, struct device_attribute *attr,
 }
 static DEVICE_ATTR(chgstate, S_IRUGO | S_IWUSR, show_chgstate, NULL);
 
-/***********************************************************************
- * RTC
- ***********************************************************************/
-enum pcf50633_time_indexes {
-	PCF50633_TI_SEC = 0,
-	PCF50633_TI_MIN,
-	PCF50633_TI_HOUR,
-	PCF50633_TI_WKDAY,
-	PCF50633_TI_DAY,
-	PCF50633_TI_MONTH,
-	PCF50633_TI_YEAR,
-	PCF50633_TI_EXTENT /* always last */
-};
-
-
-struct pcf50633_time {
-	u_int8_t time[PCF50633_TI_EXTENT];
-};
-
-static void pcf2rtc_time(struct rtc_time *rtc, struct pcf50633_time *pcf)
-{
-	rtc->tm_sec = bcd2bin(pcf->time[PCF50633_TI_SEC]);
-	rtc->tm_min = bcd2bin(pcf->time[PCF50633_TI_MIN]);
-	rtc->tm_hour = bcd2bin(pcf->time[PCF50633_TI_HOUR]);
-	rtc->tm_wday = bcd2bin(pcf->time[PCF50633_TI_WKDAY]);
-	rtc->tm_mday = bcd2bin(pcf->time[PCF50633_TI_DAY]);
-	rtc->tm_mon = bcd2bin(pcf->time[PCF50633_TI_MONTH]);
-	rtc->tm_year = bcd2bin(pcf->time[PCF50633_TI_YEAR]) + 100;
-}
-
-static void rtc2pcf_time(struct pcf50633_time *pcf, struct rtc_time *rtc)
-{
-	pcf->time[PCF50633_TI_SEC] = bin2bcd(rtc->tm_sec);
-	pcf->time[PCF50633_TI_MIN] = bin2bcd(rtc->tm_min);
-	pcf->time[PCF50633_TI_HOUR] = bin2bcd(rtc->tm_hour);
-	pcf->time[PCF50633_TI_WKDAY] = bin2bcd(rtc->tm_wday);
-	pcf->time[PCF50633_TI_DAY] = bin2bcd(rtc->tm_mday);
-	pcf->time[PCF50633_TI_MONTH] = bin2bcd(rtc->tm_mon);
-	pcf->time[PCF50633_TI_YEAR] = bin2bcd(rtc->tm_year - 100);
-}
-
-static int pcf50633_rtc_ioctl(struct device *dev, unsigned int cmd,
-			      unsigned long arg)
-{
-	struct i2c_client *client = to_i2c_client(dev);
-	struct pcf50633_data *pcf = i2c_get_clientdata(client);
-
-	switch (cmd) {
-	case RTC_AIE_OFF:
-		/* disable the alarm interrupt */
-		pcf50633_reg_set_bit_mask(pcf, PCF50633_REG_INT1M,
-				 PCF50633_INT1_ALARM, PCF50633_INT1_ALARM);
-		return 0;
-	case RTC_AIE_ON:
-		/* enable the alarm interrupt */
-		pcf50633_reg_clear_bits(pcf, PCF50633_REG_INT1M, PCF50633_INT1_ALARM);
-		return 0;
-	case RTC_PIE_OFF:
-		/* disable periodic interrupt (hz tick) */
-		pcf->flags &= ~PCF50633_F_RTC_SECOND;
-		pcf50633_reg_set_bit_mask(pcf, PCF50633_REG_INT1M,
-				 PCF50633_INT1_SECOND, PCF50633_INT1_SECOND);
-		return 0;
-	case RTC_PIE_ON:
-		/* ensable periodic interrupt (hz tick) */
-		pcf->flags |= PCF50633_F_RTC_SECOND;
-		pcf50633_reg_clear_bits(pcf, PCF50633_REG_INT1M, PCF50633_INT1_SECOND);
-		return 0;
-	}
-	return -ENOIOCTLCMD;
-}
-
-static int pcf50633_rtc_read_time(struct device *dev, struct rtc_time *tm)
-{
-	struct i2c_client *client = to_i2c_client(dev);
-	struct pcf50633_data *pcf = i2c_get_clientdata(client);
-	struct pcf50633_time pcf_tm;
-	int ret;
-
-	mutex_lock(&pcf->lock);
-
-	ret = i2c_smbus_read_i2c_block_data(pcf->client,
-					    PCF50633_REG_RTCSC,
-					    PCF50633_TI_EXTENT,
-					    &pcf_tm.time[0]);
-	if (ret != PCF50633_TI_EXTENT)
-		dev_err(dev, "Failed to read time :-(\n");
-
-	mutex_unlock(&pcf->lock);
-
-	dev_dbg(dev, "PCF_TIME: %02x.%02x.%02x %02x:%02x:%02x\n",
-		pcf_tm.time[PCF50633_TI_DAY],
-		pcf_tm.time[PCF50633_TI_MONTH],
-		pcf_tm.time[PCF50633_TI_YEAR],
-		pcf_tm.time[PCF50633_TI_HOUR],
-		pcf_tm.time[PCF50633_TI_MIN],
-		pcf_tm.time[PCF50633_TI_SEC]);
-
-	pcf2rtc_time(tm, &pcf_tm);
-
-	dev_dbg(dev, "RTC_TIME: %u.%u.%u %u:%u:%u\n",
-		tm->tm_mday, tm->tm_mon, tm->tm_year,
-		tm->tm_hour, tm->tm_min, tm->tm_sec);
-
-	return 0;
-}
-
-static int pcf50633_rtc_set_time(struct device *dev, struct rtc_time *tm)
-{
-	struct i2c_client *client = to_i2c_client(dev);
-	struct pcf50633_data *pcf = i2c_get_clientdata(client);
-	struct pcf50633_time pcf_tm;
-	int ret;
-
-	dev_dbg(dev, "RTC_TIME: %u.%u.%u %u:%u:%u\n",
-		tm->tm_mday, tm->tm_mon, tm->tm_year,
-		tm->tm_hour, tm->tm_min, tm->tm_sec);
-	rtc2pcf_time(&pcf_tm, tm);
-	dev_dbg(dev, "PCF_TIME: %02x.%02x.%02x %02x:%02x:%02x\n",
-		pcf_tm.time[PCF50633_TI_DAY],
-		pcf_tm.time[PCF50633_TI_MONTH],
-		pcf_tm.time[PCF50633_TI_YEAR],
-		pcf_tm.time[PCF50633_TI_HOUR],
-		pcf_tm.time[PCF50633_TI_MIN],
-		pcf_tm.time[PCF50633_TI_SEC]);
-
-	mutex_lock(&pcf->lock);
-	/* FIXME: disable second interrupt */
-
-	ret = i2c_smbus_write_i2c_block_data(pcf->client,
-					     PCF50633_REG_RTCSC,
-					     PCF50633_TI_EXTENT,
-					     &pcf_tm.time[0]);
-	if (ret)
-		dev_err(dev, "Failed to set time %d\n", ret);
-
-	/* FIXME: re-enable second interrupt */
-	mutex_unlock(&pcf->lock);
-
-	return 0;
-}
-
-static int pcf50633_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
-{
-	struct i2c_client *client = to_i2c_client(dev);
-	struct pcf50633_data *pcf = i2c_get_clientdata(client);
-	struct pcf50633_time pcf_tm;
-	int ret;
-
-	mutex_lock(&pcf->lock);
-
-	alrm->enabled =
-	     __reg_read(pcf, PCF50633_REG_INT1M) & PCF50633_INT1_ALARM ? 0 : 1;
-
-	ret = i2c_smbus_read_i2c_block_data(pcf->client,
-					    PCF50633_REG_RTCSCA,
-					    PCF50633_TI_EXTENT,
-					    &pcf_tm.time[0]);
-	if (ret != PCF50633_TI_EXTENT)
-		dev_err(dev, "Failed to read Alarm time :-(\n");
-
-	mutex_unlock(&pcf->lock);
-
-	pcf2rtc_time(&alrm->time, &pcf_tm);
-
-	return 0;
-}
-
-static int pcf50633_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
-{
-	struct i2c_client *client = to_i2c_client(dev);
-	struct pcf50633_data *pcf = i2c_get_clientdata(client);
-	struct pcf50633_time pcf_tm;
-	u_int8_t irqmask;
-	int ret;
-
-	rtc2pcf_time(&pcf_tm, &alrm->time);
-
-	mutex_lock(&pcf->lock);
-
-	/* disable alarm interrupt */
-	irqmask = __reg_read(pcf, PCF50633_REG_INT1M);
-	irqmask |= PCF50633_INT1_ALARM;
-	__reg_write(pcf, PCF50633_REG_INT1M, irqmask);
-
-	ret = i2c_smbus_write_i2c_block_data(pcf->client,
-					     PCF50633_REG_RTCSCA,
-					     PCF50633_TI_EXTENT,
-					     &pcf_tm.time[0]);
-	if (ret)
-		dev_err(dev, "Failed to write alarm time :-( %d\n", ret);
-
-	if (alrm->enabled) {
-		/* (re-)enaable alarm interrupt */
-		irqmask = __reg_read(pcf, PCF50633_REG_INT1M);
-		irqmask &= ~PCF50633_INT1_ALARM;
-		__reg_write(pcf, PCF50633_REG_INT1M, irqmask);
-	}
-
-	mutex_unlock(&pcf->lock);
-
-	/* FIXME */
-	return 0;
-}
-
-static struct rtc_class_ops pcf50633_rtc_ops = {
-	.ioctl		= pcf50633_rtc_ioctl,
-	.read_time	= pcf50633_rtc_read_time,
-	.set_time	= pcf50633_rtc_set_time,
-	.read_alarm	= pcf50633_rtc_read_alarm,
-	.set_alarm	= pcf50633_rtc_set_alarm,
-};
-
 /*
  * Charger type
  */
@@ -1705,6 +1473,11 @@ static void populate_sysfs_group(struct pcf50633_data *pcf)
 
 }
 
+static struct platform_device pcf50633_rtc_pdev = {
+	.name	= "pcf50633-rtc",
+	.id	= -1,
+};
+
 static int pcf50633_probe(struct i2c_client *client, const struct i2c_device_id *ids)
 {
 	struct pcf50633_data *pcf;
@@ -1804,12 +1577,11 @@ static int pcf50633_probe(struct i2c_client *client, const struct i2c_device_id
 		        "source in this hardware revision!", irq);
 
 	if (pcf->pdata->used_features & PCF50633_FEAT_RTC) {
-		pcf->rtc = rtc_device_register("pcf50633", &client->dev,
-						&pcf50633_rtc_ops, THIS_MODULE);
-		if (IS_ERR(pcf->rtc)) {
-			err = PTR_ERR(pcf->rtc);
+		pcf50633_rtc_pdev.dev.platform_data = pcf;
+		
+		err = platform_device_register(&pcf50633_rtc_pdev);
+		if (err)
 			goto exit_irq;
-		}
 	}
 
 	if (pcf->pdata->flag_use_apm_emulation)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 8abbb2020af..e8a1c7c5420 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -219,6 +219,12 @@ config RTC_DRV_PCF8583
 	  This driver can also be built as a module. If so, the module
 	  will be called rtc-pcf8583.
 
+config RTC_DRV_PCF50633
+	tristate "Philips PCF50633"
+	help
+	  If you say yes here you get support for the Philips PCF50633
+	  PMU's RTC driver.
+
 config RTC_DRV_M41T80
 	tristate "ST M41T65/M41T80/81/82/83/84/85/87"
 	help
diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile
index e9e8474cc8f..ab3a003991e 100644
--- a/drivers/rtc/Makefile
+++ b/drivers/rtc/Makefile
@@ -49,6 +49,7 @@ obj-$(CONFIG_RTC_DRV_MAX6902)	+= rtc-max6902.o
 obj-$(CONFIG_RTC_DRV_OMAP)	+= rtc-omap.o
 obj-$(CONFIG_RTC_DRV_PCF8563)	+= rtc-pcf8563.o
 obj-$(CONFIG_RTC_DRV_PCF8583)	+= rtc-pcf8583.o
+obj-$(CONFIG_RTC_DRV_PCF50633)	+= rtc-pcf50633.o
 obj-$(CONFIG_RTC_DRV_PL030)	+= rtc-pl030.o
 obj-$(CONFIG_RTC_DRV_PL031)	+= rtc-pl031.o
 obj-$(CONFIG_RTC_DRV_PARISC)	+= rtc-parisc.o
diff --git a/drivers/rtc/rtc-pcf50633.c b/drivers/rtc/rtc-pcf50633.c
new file mode 100644
index 00000000000..74b7e569d39
--- /dev/null
+++ b/drivers/rtc/rtc-pcf50633.c
@@ -0,0 +1,272 @@
+#include <linux/rtc.h>
+#include <linux/platform_device.h>
+#include <linux/bcd.h>
+#include <linux/pcf50633.h>
+#include <linux/rtc/pcf50633.h>
+#include <linux/i2c.h>
+
+enum pcf50633_time_indexes {
+	PCF50633_TI_SEC = 0,
+	PCF50633_TI_MIN,
+	PCF50633_TI_HOUR,
+	PCF50633_TI_WKDAY,
+	PCF50633_TI_DAY,
+	PCF50633_TI_MONTH,
+	PCF50633_TI_YEAR,
+	PCF50633_TI_EXTENT /* always last */
+};
+
+
+struct pcf50633_time {
+	u_int8_t time[PCF50633_TI_EXTENT];
+};
+
+static void pcf2rtc_time(struct rtc_time *rtc, struct pcf50633_time *pcf)
+{
+	rtc->tm_sec = bcd2bin(pcf->time[PCF50633_TI_SEC]);
+	rtc->tm_min = bcd2bin(pcf->time[PCF50633_TI_MIN]);
+	rtc->tm_hour = bcd2bin(pcf->time[PCF50633_TI_HOUR]);
+	rtc->tm_wday = bcd2bin(pcf->time[PCF50633_TI_WKDAY]);
+	rtc->tm_mday = bcd2bin(pcf->time[PCF50633_TI_DAY]);
+	rtc->tm_mon = bcd2bin(pcf->time[PCF50633_TI_MONTH]);
+	rtc->tm_year = bcd2bin(pcf->time[PCF50633_TI_YEAR]) + 100;
+}
+
+static void rtc2pcf_time(struct pcf50633_time *pcf, struct rtc_time *rtc)
+{
+	pcf->time[PCF50633_TI_SEC] = bin2bcd(rtc->tm_sec);
+	pcf->time[PCF50633_TI_MIN] = bin2bcd(rtc->tm_min);
+	pcf->time[PCF50633_TI_HOUR] = bin2bcd(rtc->tm_hour);
+	pcf->time[PCF50633_TI_WKDAY] = bin2bcd(rtc->tm_wday);
+	pcf->time[PCF50633_TI_DAY] = bin2bcd(rtc->tm_mday);
+	pcf->time[PCF50633_TI_MONTH] = bin2bcd(rtc->tm_mon);
+	pcf->time[PCF50633_TI_YEAR] = bin2bcd(rtc->tm_year - 100);
+}
+
+static int pcf50633_rtc_ioctl(struct device *dev, unsigned int cmd,
+			      unsigned long arg)
+{
+	struct pcf50633_data *pcf = dev->platform_data;
+
+	switch (cmd) {
+	case RTC_AIE_OFF:
+		/* disable the alarm interrupt */
+		pcf50633_reg_set_bit_mask(pcf, PCF50633_REG_INT1M,
+				 PCF50633_INT1_ALARM, PCF50633_INT1_ALARM);
+		return 0;
+	case RTC_AIE_ON:
+		/* enable the alarm interrupt */
+		pcf50633_reg_clear_bits(pcf, PCF50633_REG_INT1M, PCF50633_INT1_ALARM);
+		return 0;
+	case RTC_PIE_OFF:
+		/* disable periodic interrupt (hz tick) */
+		pcf->flags &= ~PCF50633_F_RTC_SECOND;
+		pcf50633_reg_set_bit_mask(pcf, PCF50633_REG_INT1M,
+				 PCF50633_INT1_SECOND, PCF50633_INT1_SECOND);
+		return 0;
+	case RTC_PIE_ON:
+		/* ensable periodic interrupt (hz tick) */
+		pcf->flags |= PCF50633_F_RTC_SECOND;
+		pcf50633_reg_clear_bits(pcf, PCF50633_REG_INT1M, PCF50633_INT1_SECOND);
+		return 0;
+	}
+	return -ENOIOCTLCMD;
+}
+
+#ifdef PCF50633_RTC
+void pcf50633_rtc_handle_event(struct pcf50633_data *pcf,
+					enum pcf50633_rtc_event evt)
+{
+	switch(evt) {
+		case PCF50633_RTC_EVENT_ALARM:
+			rtc_update_irq(pcf->rtc, 1, RTC_AF | RTC_IRQF);
+			break;
+		case PCF50633_RTC_EVENT_SECOND:
+			rtc_update_irq(pcf->rtc, 1, RTC_PF | RTC_IRQF);
+	}
+}
+#else
+void pcf50633_rtc_handle_event(struct pcf50633_data *pcf,
+					enum pcf50633_rtc_event evt)
+{
+
+}
+#endif
+
+static int pcf50633_rtc_read_time(struct device *dev, struct rtc_time *tm)
+{
+	struct pcf50633_data *pcf = dev->platform_data;
+	struct pcf50633_time pcf_tm;
+	int ret;
+
+	mutex_lock(&pcf->lock);
+
+	ret = i2c_smbus_read_i2c_block_data(pcf->client,
+					    PCF50633_REG_RTCSC,
+					    PCF50633_TI_EXTENT,
+					    &pcf_tm.time[0]);
+	if (ret != PCF50633_TI_EXTENT)
+		dev_err(dev, "Failed to read time :-(\n");
+
+	mutex_unlock(&pcf->lock);
+
+	dev_dbg(dev, "PCF_TIME: %02x.%02x.%02x %02x:%02x:%02x\n",
+		pcf_tm.time[PCF50633_TI_DAY],
+		pcf_tm.time[PCF50633_TI_MONTH],
+		pcf_tm.time[PCF50633_TI_YEAR],
+		pcf_tm.time[PCF50633_TI_HOUR],
+		pcf_tm.time[PCF50633_TI_MIN],
+		pcf_tm.time[PCF50633_TI_SEC]);
+
+	pcf2rtc_time(tm, &pcf_tm);
+
+	dev_dbg(dev, "RTC_TIME: %u.%u.%u %u:%u:%u\n",
+		tm->tm_mday, tm->tm_mon, tm->tm_year,
+		tm->tm_hour, tm->tm_min, tm->tm_sec);
+
+	return 0;
+}
+
+static int pcf50633_rtc_set_time(struct device *dev, struct rtc_time *tm)
+{
+	struct pcf50633_data *pcf = dev->platform_data;
+	struct pcf50633_time pcf_tm;
+	int ret;
+
+	dev_dbg(dev, "RTC_TIME: %u.%u.%u %u:%u:%u\n",
+		tm->tm_mday, tm->tm_mon, tm->tm_year,
+		tm->tm_hour, tm->tm_min, tm->tm_sec);
+	rtc2pcf_time(&pcf_tm, tm);
+	dev_dbg(dev, "PCF_TIME: %02x.%02x.%02x %02x:%02x:%02x\n",
+		pcf_tm.time[PCF50633_TI_DAY],
+		pcf_tm.time[PCF50633_TI_MONTH],
+		pcf_tm.time[PCF50633_TI_YEAR],
+		pcf_tm.time[PCF50633_TI_HOUR],
+		pcf_tm.time[PCF50633_TI_MIN],
+		pcf_tm.time[PCF50633_TI_SEC]);
+
+	mutex_lock(&pcf->lock);
+	/* FIXME: disable second interrupt */
+
+	ret = i2c_smbus_write_i2c_block_data(pcf->client,
+					     PCF50633_REG_RTCSC,
+					     PCF50633_TI_EXTENT,
+					     &pcf_tm.time[0]);
+	if (ret)
+		dev_err(dev, "Failed to set time %d\n", ret);
+
+	/* FIXME: re-enable second interrupt */
+	mutex_unlock(&pcf->lock);
+
+	return 0;
+}
+
+static int pcf50633_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
+{
+	struct pcf50633_data *pcf = dev->platform_data;
+	struct pcf50633_time pcf_tm;
+	int ret;
+	u_int8_t reg;
+
+	mutex_lock(&pcf->lock);
+	
+	pcf50633_read(pcf, PCF50633_REG_INT1M, 1, &reg);     
+	alrm->enabled = reg & PCF50633_INT1_ALARM ? 0 : 1;
+
+	ret = pcf50633_read(pcf, PCF50633_REG_RTCSCA,
+				PCF50633_TI_EXTENT, &pcf_tm.time[0]);
+
+	if (ret != PCF50633_TI_EXTENT)
+		dev_err(dev, "Failed to read Alarm time :-(\n");
+
+	mutex_unlock(&pcf->lock);
+
+	pcf2rtc_time(&alrm->time, &pcf_tm);
+
+	return 0;
+}
+
+static int pcf50633_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
+{
+	struct pcf50633_data *pcf = dev->platform_data;
+	struct pcf50633_time pcf_tm;
+	u_int8_t irqmask;
+	int ret;
+
+	rtc2pcf_time(&pcf_tm, &alrm->time);
+
+	mutex_lock(&pcf->lock);
+
+	/* disable alarm interrupt */
+	pcf50633_read(pcf, PCF50633_REG_INT1M, 1, &irqmask);
+	irqmask |= PCF50633_INT1_ALARM;
+	pcf50633_write(pcf, PCF50633_REG_INT1M, 1, &irqmask);
+
+	ret = pcf50633_write(pcf, PCF50633_REG_RTCSCA,
+					PCF50633_TI_EXTENT, &pcf_tm.time[0]);
+	if (ret)
+		dev_err(dev, "Failed to write alarm time :-( %d\n", ret);
+
+	if (alrm->enabled) {
+		/* (re-)enaable alarm interrupt */
+		pcf50633_read(pcf, PCF50633_REG_INT1M, 1, &irqmask);
+		irqmask &= ~PCF50633_INT1_ALARM;
+		pcf50633_write(pcf, PCF50633_REG_INT1M, 1, &irqmask);
+	}
+
+	mutex_unlock(&pcf->lock);
+
+	/* FIXME */
+	return 0;
+}
+static struct rtc_class_ops pcf50633_rtc_ops = {
+	.ioctl		= pcf50633_rtc_ioctl,
+	.read_time	= pcf50633_rtc_read_time,
+	.set_time	= pcf50633_rtc_set_time,
+	.read_alarm	= pcf50633_rtc_read_alarm,
+	.set_alarm	= pcf50633_rtc_set_alarm,
+};
+
+static int pcf50633_rtc_probe(struct platform_device *pdev)
+{
+	struct rtc_device *rtc;
+
+	rtc = rtc_device_register("pcf50633", &pdev->dev,
+					&pcf50633_rtc_ops, THIS_MODULE);
+	if (IS_ERR(rtc))
+		return -ENODEV;
+	
+	return 0;
+}
+
+static int pcf50633_rtc_remove(struct platform_device *pdev)
+{
+	return 0;
+}
+
+
+static struct platform_driver pcf50633_rtc_driver = {
+	.driver = {
+		.name = "pcf50633-rtc",
+	},
+	.probe = pcf50633_rtc_probe,
+	.remove = __devexit_p(pcf50633_rtc_remove),
+};
+
+static int __init pcf50633_rtc_init(void)
+{
+	return platform_driver_register(&pcf50633_rtc_driver);
+}
+module_init(pcf50633_rtc_init);
+
+static void __exit pcf50633_rtc_exit(void)
+{
+	platform_driver_unregister(&pcf50633_rtc_driver);
+}
+module_exit(pcf50633_rtc_exit);
+
+
+MODULE_DESCRIPTION("RTC driver for NXP PCF50633 power management unit");
+MODULE_AUTHOR("Balaji Rao <balajirrao@openmoko.org>");
+MODULE_LICENSE("GPL");
+