aboutsummaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorJason Wessel <jason.wessel@windriver.com>2008-08-01 08:39:34 -0500
committerJason Wessel <jason.wessel@windriver.com>2008-08-01 08:39:34 -0500
commita9b60bf4c29e07a5a2f26a6f74937972fee9b58b (patch)
tree6862f0442a9ab4e2da20fb93e3cf3be2c36b76b2 /lib
parent5f5ddfb3605d2a4f555a7ff034859e623eafcd27 (diff)
kgdb: fix kgdb_validate_break_address to perform a mem write
A regression to the kgdb core was found in the case of using the CONFIG_DEBUG_RODATA kernel option. When this option is on, a breakpoint cannot be written into any readonly memory page. When an external debugger requests a breakpoint to get set, the kgdb_validate_break_address() was only checking to see if the address to place the breakpoint was readable and lacked a write check. This patch changes the validate routine to try reading (via the breakpoint set request) and also to try immediately writing the break point. If either fails, an error is correctly returned and the debugger behaves correctly. Then an end user can make the descision to use hardware breakpoints. Also update the documentation to reflect that using CONFIG_DEBUG_RODATA will inhibit the use of software breakpoints. Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions