diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2009-05-17 20:55:16 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-05-17 20:55:16 -0700 |
commit | 9d21493b4beb8f918ba248032fefa393074a5e2b (patch) | |
tree | 653590f3e325da5c4c1fc7d2c00bc196a3167f9d /net/core | |
parent | 0a305720ee597aad41af61e6b6844321d3e24251 (diff) |
net: tx scalability works : trans_start
struct net_device trans_start field is a hot spot on SMP and high performance
devices, particularly multi queues ones, because every transmitter dirties
it. Is main use is tx watchdog and bonding alive checks.
But as most devices dont use NETIF_F_LLTX, we have to lock
a netdev_queue before calling their ndo_start_xmit(). So it makes
sense to move trans_start from net_device to netdev_queue. Its update
will occur on a already present (and in exclusive state) cache line, for
free.
We can do this transition smoothly. An old driver continue to
update dev->trans_start, while an updated one updates txq->trans_start.
Further patches could also put tx_bytes/tx_packets counters in
netdev_queue to avoid dirtying dev->stats (vlan device comes to mind)
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
0 files changed, 0 insertions, 0 deletions