diff options
author | Eric W. Biederman <ebiederm@aristanetworks.com> | 2008-12-29 18:21:48 -0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-12-29 18:21:48 -0800 |
commit | 8eb79863962bbf18ebf648335e329bfd468432fa (patch) | |
tree | bd700ccdbed8aee9c36d9a20d139fe577cda766a /net/sysctl_net.c | |
parent | 91b208c7c1db4cefa2247f8243fbda75b0472d24 (diff) |
netns: foreach_netdev_safe is insufficient in default_device_exit
During network namespace teardown we either move or delete
all of the network devices associated with a network namespace.
In the case of veth devices deleting one will also delete it's
pair device. If both devices are in the same network namespace
then for_each_netdev_safe is insufficient as next may point
to the second veth device we have deleted.
To avoid problems I do what we do in __rtnl_kill_links and
restart the scan of the device list, after we have deleted
a device.
Currently dev_change_netnamespace does not appear to suffer from
this problem, but wireless devices are also paired and likely
should be moved between network namespaces together. So I have
errored on the side of caution and restart the scan of the network
devices in that case as well.
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sysctl_net.c')
0 files changed, 0 insertions, 0 deletions