summaryrefslogtreecommitdiff
path: root/src/mesa/drivers/dri/r300/r300_texstate.c
blob: bce350cba4ee6b51217e84a1de0a13e7adfd8f27 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
/* $XFree86: xc/lib/GL/mesa/src/drv/r300/r300_texstate.c,v 1.3 2003/02/15 22:18:47 dawes Exp $ */
/*
Copyright (C) The Weather Channel, Inc.  2002.  All Rights Reserved.

The Weather Channel (TM) funded Tungsten Graphics to develop the
initial release of the Radeon 8500 driver under the XFree86 license.
This notice must be preserved.

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice (including the
next paragraph) shall be included in all copies or substantial
portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

**************************************************************************/

/*
 * Authors:
 *   Keith Whitwell <keith@tungstengraphics.com>
 */

#include "glheader.h"
#include "imports.h"
#include "context.h"
#include "macros.h"
#include "texformat.h"
#include "enums.h"

#include "r300_context.h"
#include "r300_state.h"
#include "r300_ioctl.h"
#include "radeon_ioctl.h"
//#include "r300_swtcl.h"
#include "r300_tex.h"
//#include "r300_tcl.h"
#include "r300_reg.h"

#define R200_TXFORMAT_A8        R200_TXFORMAT_I8
#define R200_TXFORMAT_L8        R200_TXFORMAT_I8
#define R200_TXFORMAT_AL88      R200_TXFORMAT_AI88
#define R200_TXFORMAT_YCBCR     R200_TXFORMAT_YVYU422
#define R200_TXFORMAT_YCBCR_REV R200_TXFORMAT_VYUY422
#define R200_TXFORMAT_RGB_DXT1  R200_TXFORMAT_DXT1
#define R200_TXFORMAT_RGBA_DXT1 R200_TXFORMAT_DXT1
#define R200_TXFORMAT_RGBA_DXT3 R200_TXFORMAT_DXT23
#define R200_TXFORMAT_RGBA_DXT5 R200_TXFORMAT_DXT45

#define _COLOR(f) \
    [ MESA_FORMAT_ ## f ] = { R200_TXFORMAT_ ## f, 0 }
#define _COLOR_REV(f) \
    [ MESA_FORMAT_ ## f ## _REV ] = { R200_TXFORMAT_ ## f, 0 }
#define _ALPHA(f) \
    [ MESA_FORMAT_ ## f ] = { R200_TXFORMAT_ ## f | R200_TXFORMAT_ALPHA_IN_MAP, 0 }
#define _ALPHA_REV(f) \
    [ MESA_FORMAT_ ## f ## _REV ] = { R200_TXFORMAT_ ## f | R200_TXFORMAT_ALPHA_IN_MAP, 0 }
#define _YUV(f) \
    [ MESA_FORMAT_ ## f ] = { R200_TXFORMAT_ ## f, R200_YUV_TO_RGB }
#define _INVALID(f) \
    [ MESA_FORMAT_ ## f ] = { 0xffffffff, 0 }
#define VALID_FORMAT(f) ( ((f) <= MESA_FORMAT_RGBA_DXT5) \
			     && tx_table[f].flag )

#define _ASSIGN(entry, format)	\
	[ MESA_FORMAT_ ## entry ] = { format, 0, 1}

static const struct {
	GLuint format, filter;
} tx_table0[] = {
	    _ALPHA(RGBA8888),
	    _ALPHA_REV(RGBA8888),
	    _ALPHA(ARGB8888),
	    _ALPHA_REV(ARGB8888),
	    _INVALID(RGB888),
	    _COLOR(RGB565),
	    _COLOR_REV(RGB565),
	    _ALPHA(ARGB4444),
	    _ALPHA_REV(ARGB4444),
	    _ALPHA(ARGB1555),
	    _ALPHA_REV(ARGB1555),
	    _ALPHA(AL88),
	    _ALPHA_REV(AL88),
	    _ALPHA(A8),
	    _COLOR(L8),
	    _ALPHA(I8),
	    _INVALID(CI8),
	    _YUV(YCBCR),
	    _YUV(YCBCR_REV),
	    _INVALID(RGB_FXT1),
	    _INVALID(RGBA_FXT1),
	    _COLOR(RGB_DXT1),
	    _ALPHA(RGBA_DXT1),
	    _ALPHA(RGBA_DXT3),
	    _ALPHA(RGBA_DXT5),
	    };

static const struct {
	GLuint format, filter, flag;
} tx_table[] = {
	/*
	 * Note that the _REV formats are the same as the non-REV formats.
	 * This is because the REV and non-REV formats are identical as a
	 * byte string, but differ when accessed as 16-bit or 32-bit words
	 * depending on the endianness of the host.  Since the textures are
	 * transferred to the R300 as a byte string (i.e. without any
	 * byte-swapping), the R300 sees the REV and non-REV formats
	 * identically.  -- paulus
	 */
	    _ASSIGN(RGBA8888, R300_EASY_TX_FORMAT(Y, Z, W, X, W8Z8Y8X8)),
	    _ASSIGN(RGBA8888_REV, R300_EASY_TX_FORMAT(Y, Z, W, X, W8Z8Y8X8)),
	    _ASSIGN(ARGB8888, R300_EASY_TX_FORMAT(X, Y, Z, W, W8Z8Y8X8)),
	    _ASSIGN(ARGB8888_REV, R300_EASY_TX_FORMAT(X, Y, Z, W, W8Z8Y8X8)),
	    _ASSIGN(RGB888, 0xffffffff),
	    _ASSIGN(RGB565, R300_EASY_TX_FORMAT(X, Y, Z, ONE, Z5Y6X5)),
	    _ASSIGN(RGB565_REV, R300_EASY_TX_FORMAT(X, Y, Z, ONE, Z5Y6X5)),
	    _ASSIGN(ARGB4444, R300_EASY_TX_FORMAT(X, Y, Z, W, W4Z4Y4X4)),
	    _ASSIGN(ARGB4444_REV, R300_EASY_TX_FORMAT(X, Y, Z, W, W4Z4Y4X4)),
	    _ASSIGN(ARGB1555, R300_EASY_TX_FORMAT(Z, Y, X, W, W1Z5Y5X5)),
	    _ASSIGN(ARGB1555_REV, R300_EASY_TX_FORMAT(Z, Y, X, W, W1Z5Y5X5)),
	    _ASSIGN(AL88, R300_EASY_TX_FORMAT(X, X, X, Y, Y8X8)),
	    _ASSIGN(AL88_REV, R300_EASY_TX_FORMAT(X, X, X, Y, Y8X8)),
	    _ASSIGN(RGB332, R300_EASY_TX_FORMAT(X, Y, Z, ONE, Z3Y3X2)),
	    _ASSIGN(A8, R300_EASY_TX_FORMAT(ZERO, ZERO, ZERO, X, X8)),
	    _ASSIGN(L8, R300_EASY_TX_FORMAT(X, X, X, ONE, X8)),
	    _ASSIGN(I8, R300_EASY_TX_FORMAT(X, X, X, X, X8)),
	    _ASSIGN(CI8, R300_EASY_TX_FORMAT(X, X, X, X, X8)),
	    _ASSIGN(YCBCR, R300_EASY_TX_FORMAT(X, Y, Z, ONE, G8R8_G8B8)|R300_TX_FORMAT_YUV_MODE ),
	    _ASSIGN(YCBCR_REV, R300_EASY_TX_FORMAT(X, Y, Z, ONE, G8R8_G8B8)|R300_TX_FORMAT_YUV_MODE),
	    _ASSIGN(RGB_DXT1, R300_EASY_TX_FORMAT(X, Y, Z, ONE, DXT1)),
	    _ASSIGN(RGBA_DXT1, R300_EASY_TX_FORMAT(X, Y, Z, W, DXT1)),
	    _ASSIGN(RGBA_DXT3, R300_EASY_TX_FORMAT(X, Y, Z, W, DXT3)),
	    _ASSIGN(RGBA_DXT5, R300_EASY_TX_FORMAT(Y, Z, W, X, DXT5)),
	    };

#undef _COLOR
#undef _ALPHA
#undef _INVALID
#undef _ASSIGN


/**
 * This function computes the number of bytes of storage needed for
 * the given texture object (all mipmap levels, all cube faces).
 * The \c image[face][level].x/y/width/height parameters for upload/blitting
 * are computed here.  \c filter, \c format, etc. will be set here
 * too.
 *
 * \param rmesa Context pointer
 * \param tObj GL texture object whose images are to be posted to
 *                 hardware state.
 */
static void r300SetTexImages(r300ContextPtr rmesa,
			     struct gl_texture_object *tObj)
{
	r300TexObjPtr t = (r300TexObjPtr) tObj->DriverData;
	const struct gl_texture_image *baseImage =
	    tObj->Image[0][tObj->BaseLevel];
	GLint curOffset, blitWidth;
	GLint i, texelBytes;
	GLint numLevels;
	GLint log2Width, log2Height, log2Depth;

	/* Set the hardware texture format
	 */

	t->format &= ~(R200_TXFORMAT_FORMAT_MASK |
			    R200_TXFORMAT_ALPHA_IN_MAP);
#if 0
	t->filter &= ~R200_YUV_TO_RGB;
#endif
	if (VALID_FORMAT(baseImage->TexFormat->MesaFormat)) {
		t->format =
		    tx_table[baseImage->TexFormat->MesaFormat].format;
#if 1
		t->filter |=
		    tx_table[baseImage->TexFormat->MesaFormat].filter;
#endif
	} else {
		_mesa_problem(NULL, "unexpected texture format in %s",
			      __FUNCTION__);
		return;
	}

	texelBytes = baseImage->TexFormat->TexelBytes;

	/* Compute which mipmap levels we really want to send to the hardware.
	 */

	driCalculateTextureFirstLastLevel((driTextureObject *) t);
	log2Width = tObj->Image[0][t->base.firstLevel]->WidthLog2;
	log2Height = tObj->Image[0][t->base.firstLevel]->HeightLog2;
	log2Depth = tObj->Image[0][t->base.firstLevel]->DepthLog2;

	numLevels = t->base.lastLevel - t->base.firstLevel + 1;

	assert(numLevels <= RADEON_MAX_TEXTURE_LEVELS);

	/* Calculate mipmap offsets and dimensions for blitting (uploading)
	 * The idea is that we lay out the mipmap levels within a block of
	 * memory organized as a rectangle of width BLIT_WIDTH_BYTES.
	 */
	curOffset = 0;
	blitWidth = BLIT_WIDTH_BYTES;

	for (i = 0; i < numLevels; i++) {
	  const struct gl_texture_image *texImage;
	  GLuint size;
	  
	  texImage = tObj->Image[0][i + t->base.firstLevel];
	  if (!texImage)
	    break;
	  
	  /* find image size in bytes */
	  if (texImage->IsCompressed) {
	    if ((t->format & R300_TX_FORMAT_DXT1) == R300_TX_FORMAT_DXT1) {
	     // fprintf(stderr,"DXT 1 %d %08X\n", texImage->Width, t->format);
	      if ((texImage->Width + 3) < 8) /* width one block */
		size = texImage->CompressedSize * 4;
	      else if ((texImage->Width + 3) < 16)
		size = texImage->CompressedSize * 2;
	      else size = texImage->CompressedSize;
	    }
	    else /* DXT3/5, 16 bytes per block */
	    {
	     // fprintf(stderr,"DXT 3/5 %d\n", texImage->Width);
	      if ((texImage->Width + 3) < 8)
		size = texImage->CompressedSize * 2;
	      else size = texImage->CompressedSize;
	    }
	    
	  } else if (tObj->Target == GL_TEXTURE_RECTANGLE_NV) {
	    size = ((texImage->Width * texelBytes + 63) & ~63) * texImage->Height;
	    blitWidth = 64 / texelBytes;
	  } else {
	    int w = (texImage->Width * texelBytes + 31) & ~31;
	    size = w * texImage->Height * texImage->Depth;
	    blitWidth = MAX2(texImage->Width, 64 / texelBytes);
	  }
	  assert(size > 0);
	  
	  if(0)
	    fprintf(stderr, "w=%d h=%d d=%d tb=%d intFormat=%d\n", texImage->Width, texImage->Height,
		    texImage->Depth, texImage->TexFormat->TexelBytes,
		    texImage->InternalFormat);
	  
	  /* Align to 32-byte offset.  It is faster to do this unconditionally
	   * (no branch penalty).
	   */
	  
	  curOffset = (curOffset + 0x1f) & ~0x1f;
	  
	  if (texelBytes) {
	    t->image[0][i].x = curOffset; /* fix x and y coords up later together with offset */
	    t->image[0][i].y = 0;
	    t->image[0][i].width = MIN2(size / texelBytes, blitWidth);
	    t->image[0][i].height = (size / texelBytes) / t->image[0][i].width;
	  } else {
	    t->image[0][i].x = curOffset % BLIT_WIDTH_BYTES;
	    t->image[0][i].y = curOffset / BLIT_WIDTH_BYTES;
	    t->image[0][i].width = MIN2(size, BLIT_WIDTH_BYTES);
	    t->image[0][i].height = size / t->image[0][i].width;
	  }
#if 0
	  /* for debugging only and only  applicable to non-rectangle targets */
	  assert(size % t->image[0][i].width == 0);
	  assert(t->image[0][i].x == 0
		 || (size < BLIT_WIDTH_BYTES
		     && t->image[0][i].height == 1));
#endif
	  
	  if (0)
	    fprintf(stderr,
		    "level %d: %dx%d x=%d y=%d w=%d h=%d size=%d at %d\n",
		    i, texImage->Width, texImage->Height,
		    t->image[0][i].x, t->image[0][i].y,
		    t->image[0][i].width, t->image[0][i].height,
		    size, curOffset);
	  
	  curOffset += size;
	  
	}
	
	/* Align the total size of texture memory block.
	 */
	t->base.totalSize =
	    (curOffset + RADEON_OFFSET_MASK) & ~RADEON_OFFSET_MASK;

	/* Setup remaining cube face blits, if needed */
	if (tObj->Target == GL_TEXTURE_CUBE_MAP) {
		GLuint face;
		for (face = 1; face < 6; face++) {
			for (i = 0; i < numLevels; i++) {
				t->image[face][i].x = t->image[0][i].x;
				t->image[face][i].y = t->image[0][i].y;
				t->image[face][i].width = t->image[0][i].width;
				t->image[face][i].height =
				    t->image[0][i].height;
			}
		}
		t->base.totalSize *= 6;	/* total texmem needed */
	}

	/* Hardware state:
	 */
#if 0
	t->filter &= ~R200_MAX_MIP_LEVEL_MASK;
	t->filter |= (numLevels - 1) << R200_MAX_MIP_LEVEL_SHIFT;
#endif
#if 0
	t->format &= ~(R200_TXFORMAT_WIDTH_MASK |
			    R200_TXFORMAT_HEIGHT_MASK |
			    R200_TXFORMAT_CUBIC_MAP_ENABLE |
			    R200_TXFORMAT_F5_WIDTH_MASK |
			    R200_TXFORMAT_F5_HEIGHT_MASK);
	t->format |= ((log2Width << R200_TXFORMAT_WIDTH_SHIFT) |
			   (log2Height << R200_TXFORMAT_HEIGHT_SHIFT));
#endif

	t->format_x &= ~(R200_DEPTH_LOG2_MASK | R200_TEXCOORD_MASK);
	if (tObj->Target == GL_TEXTURE_3D) {
		t->format_x |= (log2Depth << R200_DEPTH_LOG2_SHIFT);
		t->format_x |= R200_TEXCOORD_VOLUME;
	} else if (tObj->Target == GL_TEXTURE_CUBE_MAP) {
		ASSERT(log2Width == log2Height);
		t->format |= R300_TX_FORMAT_CUBIC_MAP;
		
		t->format_x |= R200_TEXCOORD_CUBIC_ENV;
		t->pp_cubic_faces = ((log2Width << R200_FACE_WIDTH_1_SHIFT) |
				     (log2Height << R200_FACE_HEIGHT_1_SHIFT) |
				     (log2Width << R200_FACE_WIDTH_2_SHIFT) |
				     (log2Height << R200_FACE_HEIGHT_2_SHIFT) |
				     (log2Width << R200_FACE_WIDTH_3_SHIFT) |
				     (log2Height << R200_FACE_HEIGHT_3_SHIFT) |
				     (log2Width << R200_FACE_WIDTH_4_SHIFT) |
				     (log2Height << R200_FACE_HEIGHT_4_SHIFT));
	}
	
	if (!baseImage->IsCompressed) {
		int vv;
		vv = (tObj->Image[0][t->base.firstLevel]->Width * 4) % 64;
		if (vv >= 4 && vv <= 32) {
			WARN_ONCE("Corrupted texture ahead!\n");
		}
	}

	t->size = (((tObj->Image[0][t->base.firstLevel]->Width - 1) << R300_TX_WIDTHMASK_SHIFT)
			|((tObj->Image[0][t->base.firstLevel]->Height - 1) << R300_TX_HEIGHTMASK_SHIFT));

	/* Only need to round to nearest 32 for textures, but the blitter
	 * requires 64-byte aligned pitches, and we may/may not need the
	 * blitter.   NPOT only!
	 */
	if (baseImage->IsCompressed) {
		t->pitch =
		    (tObj->Image[0][t->base.firstLevel]->Width + 63) & ~(63);
		t->size |= ((log2Width>log2Height)?log2Width:log2Height)<<R300_TX_SIZE_SHIFT;
	}
	else if (tObj->Target == GL_TEXTURE_RECTANGLE_NV) {
		unsigned int align = blitWidth - 1;
		t->pitch = ((tObj->Image[0][t->base.firstLevel]->Width *
		      texelBytes) + 63) & ~(63);
		t->size |= R300_TX_SIZE_TXPITCH_EN;
		t->pitch_reg = (((tObj->Image[0][t->base.firstLevel]->Width) + align) & ~align) - 1;
	}
	else {
		t->size |= ((log2Width>log2Height)?log2Width:log2Height)<<R300_TX_SIZE_SHIFT;
		t->pitch =
		    ((tObj->Image[0][t->base.firstLevel]->Width *
		      texelBytes) + 63) & ~(63);
	}

	t->dirty_state = TEX_ALL;

	/* FYI: r300UploadTexImages( rmesa, t ) used to be called here */
}

/* ================================================================
 * Texture combine functions
 */

/* GL_ARB_texture_env_combine support
 */

/* The color tables have combine functions for GL_SRC_COLOR,
 * GL_ONE_MINUS_SRC_COLOR, GL_SRC_ALPHA and GL_ONE_MINUS_SRC_ALPHA.
 */
static GLuint r300_register_color[][R200_MAX_TEXTURE_UNITS] = {
	{
	 R200_TXC_ARG_A_R0_COLOR,
	 R200_TXC_ARG_A_R1_COLOR,
	 R200_TXC_ARG_A_R2_COLOR,
	 R200_TXC_ARG_A_R3_COLOR,
	 R200_TXC_ARG_A_R4_COLOR,
	 R200_TXC_ARG_A_R5_COLOR},
	{
	 R200_TXC_ARG_A_R0_COLOR | R200_TXC_COMP_ARG_A,
	 R200_TXC_ARG_A_R1_COLOR | R200_TXC_COMP_ARG_A,
	 R200_TXC_ARG_A_R2_COLOR | R200_TXC_COMP_ARG_A,
	 R200_TXC_ARG_A_R3_COLOR | R200_TXC_COMP_ARG_A,
	 R200_TXC_ARG_A_R4_COLOR | R200_TXC_COMP_ARG_A,
	 R200_TXC_ARG_A_R5_COLOR | R200_TXC_COMP_ARG_A},
	{
	 R200_TXC_ARG_A_R0_ALPHA,
	 R200_TXC_ARG_A_R1_ALPHA,
	 R200_TXC_ARG_A_R2_ALPHA,
	 R200_TXC_ARG_A_R3_ALPHA,
	 R200_TXC_ARG_A_R4_ALPHA,
	 R200_TXC_ARG_A_R5_ALPHA},
	{
	 R200_TXC_ARG_A_R0_ALPHA | R200_TXC_COMP_ARG_A,
	 R200_TXC_ARG_A_R1_ALPHA | R200_TXC_COMP_ARG_A,
	 R200_TXC_ARG_A_R2_ALPHA | R200_TXC_COMP_ARG_A,
	 R200_TXC_ARG_A_R3_ALPHA | R200_TXC_COMP_ARG_A,
	 R200_TXC_ARG_A_R4_ALPHA | R200_TXC_COMP_ARG_A,
	 R200_TXC_ARG_A_R5_ALPHA | R200_TXC_COMP_ARG_A},
};

static GLuint r300_tfactor_color[] = {
	R200_TXC_ARG_A_TFACTOR_COLOR,
	R200_TXC_ARG_A_TFACTOR_COLOR | R200_TXC_COMP_ARG_A,
	R200_TXC_ARG_A_TFACTOR_ALPHA,
	R200_TXC_ARG_A_TFACTOR_ALPHA | R200_TXC_COMP_ARG_A
};

static GLuint r300_primary_color[] = {
	R200_TXC_ARG_A_DIFFUSE_COLOR,
	R200_TXC_ARG_A_DIFFUSE_COLOR | R200_TXC_COMP_ARG_A,
	R200_TXC_ARG_A_DIFFUSE_ALPHA,
	R200_TXC_ARG_A_DIFFUSE_ALPHA | R200_TXC_COMP_ARG_A
};

/* GL_ZERO table - indices 0-3
 * GL_ONE  table - indices 1-4
 */
static GLuint r300_zero_color[] = {
	R200_TXC_ARG_A_ZERO,
	R200_TXC_ARG_A_ZERO | R200_TXC_COMP_ARG_A,
	R200_TXC_ARG_A_ZERO,
	R200_TXC_ARG_A_ZERO | R200_TXC_COMP_ARG_A,
	R200_TXC_ARG_A_ZERO
};

/* The alpha tables only have GL_SRC_ALPHA and GL_ONE_MINUS_SRC_ALPHA.
 */
static GLuint r300_register_alpha[][R200_MAX_TEXTURE_UNITS] = {
	{
	 R200_TXA_ARG_A_R0_ALPHA,
	 R200_TXA_ARG_A_R1_ALPHA,
	 R200_TXA_ARG_A_R2_ALPHA,
	 R200_TXA_ARG_A_R3_ALPHA,
	 R200_TXA_ARG_A_R4_ALPHA,
	 R200_TXA_ARG_A_R5_ALPHA},
	{
	 R200_TXA_ARG_A_R0_ALPHA | R200_TXA_COMP_ARG_A,
	 R200_TXA_ARG_A_R1_ALPHA | R200_TXA_COMP_ARG_A,
	 R200_TXA_ARG_A_R2_ALPHA | R200_TXA_COMP_ARG_A,
	 R200_TXA_ARG_A_R3_ALPHA | R200_TXA_COMP_ARG_A,
	 R200_TXA_ARG_A_R4_ALPHA | R200_TXA_COMP_ARG_A,
	 R200_TXA_ARG_A_R5_ALPHA | R200_TXA_COMP_ARG_A},
};

static GLuint r300_tfactor_alpha[] = {
	R200_TXA_ARG_A_TFACTOR_ALPHA,
	R200_TXA_ARG_A_TFACTOR_ALPHA | R200_TXA_COMP_ARG_A
};

static GLuint r300_primary_alpha[] = {
	R200_TXA_ARG_A_DIFFUSE_ALPHA,
	R200_TXA_ARG_A_DIFFUSE_ALPHA | R200_TXA_COMP_ARG_A
};

/* GL_ZERO table - indices 0-1
 * GL_ONE  table - indices 1-2
 */
static GLuint r300_zero_alpha[] = {
	R200_TXA_ARG_A_ZERO,
	R200_TXA_ARG_A_ZERO | R200_TXA_COMP_ARG_A,
	R200_TXA_ARG_A_ZERO,
};

/* Extract the arg from slot A, shift it into the correct argument slot
 * and set the corresponding complement bit.
 */
#define R200_COLOR_ARG( n, arg )			\
do {							\
   color_combine |=					\
      ((color_arg[n] & R200_TXC_ARG_A_MASK)		\
       << R200_TXC_ARG_##arg##_SHIFT);			\
   color_combine |=					\
      ((color_arg[n] >> R200_TXC_COMP_ARG_A_SHIFT)	\
       << R200_TXC_COMP_ARG_##arg##_SHIFT);		\
} while (0)

#define R200_ALPHA_ARG( n, arg )			\
do {							\
   alpha_combine |=					\
      ((alpha_arg[n] & R200_TXA_ARG_A_MASK)		\
       << R200_TXA_ARG_##arg##_SHIFT);			\
   alpha_combine |=					\
      ((alpha_arg[n] >> R200_TXA_COMP_ARG_A_SHIFT)	\
       << R200_TXA_COMP_ARG_##arg##_SHIFT);		\
} while (0)

/* ================================================================
 * Texture unit state management
 */

static GLboolean r300UpdateTextureEnv(GLcontext * ctx, int unit)
{
	r300ContextPtr rmesa = R300_CONTEXT(ctx);
	const struct gl_texture_unit *texUnit = &ctx->Texture.Unit[unit];
	GLuint color_combine, alpha_combine;

#if 0 /* disable for now.. */
	GLuint color_scale = rmesa->hw.pix[unit].cmd[PIX_PP_TXCBLEND2] &
	    ~(R200_TXC_SCALE_MASK);
	GLuint alpha_scale = rmesa->hw.pix[unit].cmd[PIX_PP_TXABLEND2] &
	    ~(R200_TXA_DOT_ALPHA | R200_TXA_SCALE_MASK);
#endif

	GLuint color_scale=0, alpha_scale=0;

	/* texUnit->_Current can be NULL if and only if the texture unit is
	 * not actually enabled.
	 */
	assert((texUnit->_ReallyEnabled == 0)
	       || (texUnit->_Current != NULL));

	if (RADEON_DEBUG & DEBUG_TEXTURE) {
		fprintf(stderr, "%s( %p, %d )\n", __FUNCTION__, (void *)ctx,
			unit);
	}

	/* Set the texture environment state.  Isn't this nice and clean?
	 * The chip will automagically set the texture alpha to 0xff when
	 * the texture format does not include an alpha component.  This
	 * reduces the amount of special-casing we have to do, alpha-only
	 * textures being a notable exception.
	 */
	/* Don't cache these results.
	 */
#if 0
	rmesa->state.texture.unit[unit].format = 0;
#endif
	rmesa->state.texture.unit[unit].envMode = 0;


	if (!texUnit->_ReallyEnabled) {
		if (unit == 0) {
			color_combine =
			    R200_TXC_ARG_A_ZERO | R200_TXC_ARG_B_ZERO |
			    R200_TXC_ARG_C_DIFFUSE_COLOR | R200_TXC_OP_MADD;
			alpha_combine =
			    R200_TXA_ARG_A_ZERO | R200_TXA_ARG_B_ZERO |
			    R200_TXA_ARG_C_DIFFUSE_ALPHA | R200_TXA_OP_MADD;
		} else {
			color_combine =
			    R200_TXC_ARG_A_ZERO | R200_TXC_ARG_B_ZERO |
			    R200_TXC_ARG_C_R0_COLOR | R200_TXC_OP_MADD;
			alpha_combine =
			    R200_TXA_ARG_A_ZERO | R200_TXA_ARG_B_ZERO |
			    R200_TXA_ARG_C_R0_ALPHA | R200_TXA_OP_MADD;
		}
	} else {
		GLuint color_arg[3], alpha_arg[3];
		GLuint i;
		const GLuint numColorArgs =
		    texUnit->_CurrentCombine->_NumArgsRGB;
		const GLuint numAlphaArgs = texUnit->_CurrentCombine->_NumArgsA;
		GLuint RGBshift = texUnit->_CurrentCombine->ScaleShiftRGB;
		GLuint Ashift = texUnit->_CurrentCombine->ScaleShiftA;

		/* Step 1:
		 * Extract the color and alpha combine function arguments.
		 */
		for (i = 0; i < numColorArgs; i++) {
			const GLint op =
			    texUnit->_CurrentCombine->OperandRGB[i] -
			    GL_SRC_COLOR;
			assert(op >= 0);
			assert(op <= 3);
			switch (texUnit->_CurrentCombine->SourceRGB[i]) {
			case GL_TEXTURE:
				color_arg[i] = r300_register_color[op][unit];
				break;
			case GL_CONSTANT:
				color_arg[i] = r300_tfactor_color[op];
				break;
			case GL_PRIMARY_COLOR:
				color_arg[i] = r300_primary_color[op];
				break;
			case GL_PREVIOUS:
				if (unit == 0)
					color_arg[i] = r300_primary_color[op];
				else
					color_arg[i] =
					    r300_register_color[op][0];
				break;
			case GL_ZERO:
				color_arg[i] = r300_zero_color[op];
				break;
			case GL_ONE:
				color_arg[i] = r300_zero_color[op + 1];
				break;
			default:
				return GL_FALSE;
			}
		}

		for (i = 0; i < numAlphaArgs; i++) {
			const GLint op =
			    texUnit->_CurrentCombine->OperandA[i] -
			    GL_SRC_ALPHA;
			assert(op >= 0);
			assert(op <= 1);
			switch (texUnit->_CurrentCombine->SourceA[i]) {
			case GL_TEXTURE:
				alpha_arg[i] = r300_register_alpha[op][unit];
				break;
			case GL_CONSTANT:
				alpha_arg[i] = r300_tfactor_alpha[op];
				break;
			case GL_PRIMARY_COLOR:
				alpha_arg[i] = r300_primary_alpha[op];
				break;
			case GL_PREVIOUS:
				if (unit == 0)
					alpha_arg[i] = r300_primary_alpha[op];
				else
					alpha_arg[i] =
					    r300_register_alpha[op][0];
				break;
			case GL_ZERO:
				alpha_arg[i] = r300_zero_alpha[op];
				break;
			case GL_ONE:
				alpha_arg[i] = r300_zero_alpha[op + 1];
				break;
			default:
				return GL_FALSE;
			}
		}

		/* Step 2:
		 * Build up the color and alpha combine functions.
		 */
		switch (texUnit->_CurrentCombine->ModeRGB) {
		case GL_REPLACE:
			color_combine = (R200_TXC_ARG_A_ZERO |
					 R200_TXC_ARG_B_ZERO |
					 R200_TXC_OP_MADD);
			R200_COLOR_ARG(0, C);
			break;
		case GL_MODULATE:
			color_combine = (R200_TXC_ARG_C_ZERO |
					 R200_TXC_OP_MADD);
			R200_COLOR_ARG(0, A);
			R200_COLOR_ARG(1, B);
			break;
		case GL_ADD:
			color_combine = (R200_TXC_ARG_B_ZERO |
					 R200_TXC_COMP_ARG_B |
					 R200_TXC_OP_MADD);
			R200_COLOR_ARG(0, A);
			R200_COLOR_ARG(1, C);
			break;
		case GL_ADD_SIGNED:
			color_combine = (R200_TXC_ARG_B_ZERO | R200_TXC_COMP_ARG_B | R200_TXC_BIAS_ARG_C |	/* new */
					 R200_TXC_OP_MADD);	/* was ADDSIGNED */
			R200_COLOR_ARG(0, A);
			R200_COLOR_ARG(1, C);
			break;
		case GL_SUBTRACT:
			color_combine = (R200_TXC_ARG_B_ZERO |
					 R200_TXC_COMP_ARG_B |
					 R200_TXC_NEG_ARG_C | R200_TXC_OP_MADD);
			R200_COLOR_ARG(0, A);
			R200_COLOR_ARG(1, C);
			break;
		case GL_INTERPOLATE:
			color_combine = (R200_TXC_OP_LERP);
			R200_COLOR_ARG(0, B);
			R200_COLOR_ARG(1, A);
			R200_COLOR_ARG(2, C);
			break;

		case GL_DOT3_RGB_EXT:
		case GL_DOT3_RGBA_EXT:
			/* The EXT version of the DOT3 extension does not support the
			 * scale factor, but the ARB version (and the version in OpenGL
			 * 1.3) does.
			 */
			RGBshift = 0;
			/* FALLTHROUGH */

		case GL_DOT3_RGB:
		case GL_DOT3_RGBA:
			/* DOT3 works differently on R200 than on R100.  On R100, just
			 * setting the DOT3 mode did everything for you.  On R200, the
			 * driver has to enable the biasing and scale in the inputs to
			 * put them in the proper [-1,1] range.  This is what the 4x and
			 * the -0.5 in the DOT3 spec do.  The post-scale is then set
			 * normally.
			 */

			color_combine = (R200_TXC_ARG_C_ZERO |
					 R200_TXC_OP_DOT3 |
					 R200_TXC_BIAS_ARG_A |
					 R200_TXC_BIAS_ARG_B |
					 R200_TXC_SCALE_ARG_A |
					 R200_TXC_SCALE_ARG_B);
			R200_COLOR_ARG(0, A);
			R200_COLOR_ARG(1, B);
			break;

		case GL_MODULATE_ADD_ATI:
			color_combine = (R200_TXC_OP_MADD);
			R200_COLOR_ARG(0, A);
			R200_COLOR_ARG(1, C);
			R200_COLOR_ARG(2, B);
			break;
		case GL_MODULATE_SIGNED_ADD_ATI:
			color_combine = (R200_TXC_BIAS_ARG_C |	/* new */
					 R200_TXC_OP_MADD);	/* was ADDSIGNED */
			R200_COLOR_ARG(0, A);
			R200_COLOR_ARG(1, C);
			R200_COLOR_ARG(2, B);
			break;
		case GL_MODULATE_SUBTRACT_ATI:
			color_combine = (R200_TXC_NEG_ARG_C | R200_TXC_OP_MADD);
			R200_COLOR_ARG(0, A);
			R200_COLOR_ARG(1, C);
			R200_COLOR_ARG(2, B);
			break;
		default:
			return GL_FALSE;
		}

		switch (texUnit->_CurrentCombine->ModeA) {
		case GL_REPLACE:
			alpha_combine = (R200_TXA_ARG_A_ZERO |
					 R200_TXA_ARG_B_ZERO |
					 R200_TXA_OP_MADD);
			R200_ALPHA_ARG(0, C);
			break;
		case GL_MODULATE:
			alpha_combine = (R200_TXA_ARG_C_ZERO |
					 R200_TXA_OP_MADD);
			R200_ALPHA_ARG(0, A);
			R200_ALPHA_ARG(1, B);
			break;
		case GL_ADD:
			alpha_combine = (R200_TXA_ARG_B_ZERO |
					 R200_TXA_COMP_ARG_B |
					 R200_TXA_OP_MADD);
			R200_ALPHA_ARG(0, A);
			R200_ALPHA_ARG(1, C);
			break;
		case GL_ADD_SIGNED:
			alpha_combine = (R200_TXA_ARG_B_ZERO | R200_TXA_COMP_ARG_B | R200_TXA_BIAS_ARG_C |	/* new */
					 R200_TXA_OP_MADD);	/* was ADDSIGNED */
			R200_ALPHA_ARG(0, A);
			R200_ALPHA_ARG(1, C);
			break;
		case GL_SUBTRACT:
			alpha_combine = (R200_TXA_ARG_B_ZERO |
					 R200_TXA_COMP_ARG_B |
					 R200_TXA_NEG_ARG_C | R200_TXA_OP_MADD);
			R200_ALPHA_ARG(0, A);
			R200_ALPHA_ARG(1, C);
			break;
		case GL_INTERPOLATE:
			alpha_combine = (R200_TXA_OP_LERP);
			R200_ALPHA_ARG(0, B);
			R200_ALPHA_ARG(1, A);
			R200_ALPHA_ARG(2, C);
			break;

		case GL_MODULATE_ADD_ATI:
			alpha_combine = (R200_TXA_OP_MADD);
			R200_ALPHA_ARG(0, A);
			R200_ALPHA_ARG(1, C);
			R200_ALPHA_ARG(2, B);
			break;
		case GL_MODULATE_SIGNED_ADD_ATI:
			alpha_combine = (R200_TXA_BIAS_ARG_C |	/* new */
					 R200_TXA_OP_MADD);	/* was ADDSIGNED */
			R200_ALPHA_ARG(0, A);
			R200_ALPHA_ARG(1, C);
			R200_ALPHA_ARG(2, B);
			break;
		case GL_MODULATE_SUBTRACT_ATI:
			alpha_combine = (R200_TXA_NEG_ARG_C | R200_TXA_OP_MADD);
			R200_ALPHA_ARG(0, A);
			R200_ALPHA_ARG(1, C);
			R200_ALPHA_ARG(2, B);
			break;
		default:
			return GL_FALSE;
		}

		if ((texUnit->_CurrentCombine->ModeRGB == GL_DOT3_RGBA_EXT)
		    || (texUnit->_CurrentCombine->ModeRGB == GL_DOT3_RGBA)) {
			alpha_scale |= R200_TXA_DOT_ALPHA;
			Ashift = RGBshift;
		}

		/* Step 3:
		 * Apply the scale factor.
		 */
		color_scale |= (RGBshift << R200_TXC_SCALE_SHIFT);
		alpha_scale |= (Ashift << R200_TXA_SCALE_SHIFT);

		/* All done!
		 */
	}

#if 0
	fprintf(stderr, "color_combine=%08x alpha_combine=%08x color_scale=%08x alpha_scale=%08x\n",
		color_combine, alpha_combine, color_scale, alpha_scale);
#endif

#if 0
	if (rmesa->hw.pix[unit].cmd[PIX_PP_TXCBLEND] != color_combine ||
	    rmesa->hw.pix[unit].cmd[PIX_PP_TXABLEND] != alpha_combine ||
	    rmesa->hw.pix[unit].cmd[PIX_PP_TXCBLEND2] != color_scale ||
	    rmesa->hw.pix[unit].cmd[PIX_PP_TXABLEND2] != alpha_scale) {
		R300_STATECHANGE(rmesa, pix[unit]);
		rmesa->hw.pix[unit].cmd[PIX_PP_TXCBLEND] = color_combine;
		rmesa->hw.pix[unit].cmd[PIX_PP_TXABLEND] = alpha_combine;
		rmesa->hw.pix[unit].cmd[PIX_PP_TXCBLEND2] = color_scale;
		rmesa->hw.pix[unit].cmd[PIX_PP_TXABLEND2] = alpha_scale;
	}

#endif

	return GL_TRUE;
}

#define TEXOBJ_TXFILTER_MASK (R200_MAX_MIP_LEVEL_MASK |		\
			      R200_MIN_FILTER_MASK | 		\
			      R200_MAG_FILTER_MASK |		\
			      R200_MAX_ANISO_MASK |		\
			      R200_YUV_TO_RGB |			\
			      R200_YUV_TEMPERATURE_MASK |	\
			      R200_CLAMP_S_MASK | 		\
			      R200_CLAMP_T_MASK | 		\
			      R200_BORDER_MODE_D3D )

#define TEXOBJ_TXFORMAT_MASK (R200_TXFORMAT_WIDTH_MASK |	\
			      R200_TXFORMAT_HEIGHT_MASK |	\
			      R200_TXFORMAT_FORMAT_MASK |	\
                              R200_TXFORMAT_F5_WIDTH_MASK |	\
                              R200_TXFORMAT_F5_HEIGHT_MASK |	\
			      R200_TXFORMAT_ALPHA_IN_MAP |	\
			      R200_TXFORMAT_CUBIC_MAP_ENABLE |	\
                              R200_TXFORMAT_NON_POWER2)

#define TEXOBJ_TXFORMAT_X_MASK (R200_DEPTH_LOG2_MASK |		\
                                R200_TEXCOORD_MASK |		\
                                R200_CLAMP_Q_MASK | 		\
                                R200_VOLUME_FILTER_MASK)

static void disable_tex(GLcontext * ctx, int unit)
{
#if 0 /* This needs to be redone.. or done elsewhere */
	r300ContextPtr rmesa = R300_CONTEXT(ctx);

	if (rmesa->hw.ctx.cmd[CTX_PP_CNTL] & (R200_TEX_0_ENABLE << unit)) {
		/* Texture unit disabled */
		if (rmesa->state.texture.unit[unit].texobj != NULL) {
			/* The old texture is no longer bound to this texture unit.
			 * Mark it as such.
			 */

			rmesa->state.texture.unit[unit].texobj->base.bound &=
			    ~(1UL << unit);
			rmesa->state.texture.unit[unit].texobj = NULL;
		}

		R300_STATECHANGE(rmesa, ctx);
		rmesa->hw.ctx.cmd[CTX_PP_CNTL] &= ~((R200_TEX_0_ENABLE |
						     R200_TEX_BLEND_0_ENABLE) <<
						    unit);
		rmesa->hw.ctx.cmd[CTX_PP_CNTL] |= R200_TEX_BLEND_0_ENABLE;

		R300_STATECHANGE(rmesa, tcl);
		rmesa->hw.vtx.cmd[VTX_TCL_OUTPUT_VTXFMT_1] &=
		    ~(7 << (unit * 3));

		if (rmesa->radeon.TclFallback & (RADEON_TCL_FALLBACK_TEXGEN_0 << unit)) {
			TCL_FALLBACK(ctx, (RADEON_TCL_FALLBACK_TEXGEN_0 << unit),
				     GL_FALSE);
		}

		/* Actually want to keep all units less than max active texture
		 * enabled, right?  Fix this for >2 texunits.
		 */
		/* FIXME: What should happen here if r300UpdateTextureEnv fails? */
		if (unit == 0)
			r300UpdateTextureEnv(ctx, unit);

		{
			GLuint inputshift =
			    R200_TEXGEN_0_INPUT_SHIFT + unit * 4;
			GLuint tmp = rmesa->TexGenEnabled;

			rmesa->TexGenEnabled &=
			    ~(R200_TEXGEN_TEXMAT_0_ENABLE << unit);
			rmesa->TexGenEnabled &= ~(R200_TEXMAT_0_ENABLE << unit);
			rmesa->TexGenEnabled &=
			    ~(R200_TEXGEN_INPUT_MASK << inputshift);
			rmesa->TexGenNeedNormals[unit] = 0;
			rmesa->TexGenCompSel &= ~(R200_OUTPUT_TEX_0 << unit);
			rmesa->TexGenInputs &=
			    ~(R200_TEXGEN_INPUT_MASK << inputshift);

			if (tmp != rmesa->TexGenEnabled) {
				rmesa->recheck_texgen[unit] = GL_TRUE;
				rmesa->NewGLState |= _NEW_TEXTURE_MATRIX;
			}
		}
	}
#endif
}

static GLboolean enable_tex_2d(GLcontext * ctx, int unit)
{
	r300ContextPtr rmesa = R300_CONTEXT(ctx);
	struct gl_texture_unit *texUnit = &ctx->Texture.Unit[unit];
	struct gl_texture_object *tObj = texUnit->_Current;
	r300TexObjPtr t = (r300TexObjPtr) tObj->DriverData;

	/* Need to load the 2d images associated with this unit.
	 */
#if 0
	if (t->format & R200_TXFORMAT_NON_POWER2) {
		t->format &= ~R200_TXFORMAT_NON_POWER2;
		t->base.dirty_images[0] = ~0;
	}
#endif

	ASSERT(tObj->Target == GL_TEXTURE_2D || tObj->Target == GL_TEXTURE_1D);

	if (t->base.dirty_images[0]) {
		R300_FIREVERTICES(rmesa);
		r300SetTexImages(rmesa, tObj);
		r300UploadTexImages(rmesa, (r300TexObjPtr) tObj->DriverData, 0);
		if (!t->base.memBlock)
			return GL_FALSE;
	}

	return GL_TRUE;
}

#if ENABLE_HW_3D_TEXTURE
static GLboolean enable_tex_3d(GLcontext * ctx, int unit)
{
	r300ContextPtr rmesa = R300_CONTEXT(ctx);
	struct gl_texture_unit *texUnit = &ctx->Texture.Unit[unit];
	struct gl_texture_object *tObj = texUnit->_Current;
	r300TexObjPtr t = (r300TexObjPtr) tObj->DriverData;

	/* Need to load the 3d images associated with this unit.
	 */
	if (t->format & R200_TXFORMAT_NON_POWER2) {
		t->format &= ~R200_TXFORMAT_NON_POWER2;
		t->base.dirty_images[0] = ~0;
	}

	ASSERT(tObj->Target == GL_TEXTURE_3D);

	/* R100 & R200 do not support mipmaps for 3D textures.
	 */
	if ((tObj->MinFilter != GL_NEAREST) && (tObj->MinFilter != GL_LINEAR)) {
		return GL_FALSE;
	}

	if (t->base.dirty_images[0]) {
		R300_FIREVERTICES(rmesa);
		r300SetTexImages(rmesa, tObj);
		r300UploadTexImages(rmesa, (r300TexObjPtr) tObj->DriverData, 0);
		if (!t->base.memBlock)
			return GL_FALSE;
	}

	return GL_TRUE;
}
#endif

static GLboolean enable_tex_cube(GLcontext * ctx, int unit)
{
	r300ContextPtr rmesa = R300_CONTEXT(ctx);
	struct gl_texture_unit *texUnit = &ctx->Texture.Unit[unit];
	struct gl_texture_object *tObj = texUnit->_Current;
	r300TexObjPtr t = (r300TexObjPtr) tObj->DriverData;
	GLuint face;

	/* Need to load the 2d images associated with this unit.
	 */
	if (t->format & R200_TXFORMAT_NON_POWER2) {
		t->format &= ~R200_TXFORMAT_NON_POWER2;
		for (face = 0; face < 6; face++)
			t->base.dirty_images[face] = ~0;
	}

	ASSERT(tObj->Target == GL_TEXTURE_CUBE_MAP);

	if (t->base.dirty_images[0] || t->base.dirty_images[1] ||
	    t->base.dirty_images[2] || t->base.dirty_images[3] ||
	    t->base.dirty_images[4] || t->base.dirty_images[5]) {
		/* flush */
		R300_FIREVERTICES(rmesa);
		/* layout memory space, once for all faces */
		r300SetTexImages(rmesa, tObj);
	}

	/* upload (per face) */
	for (face = 0; face < 6; face++) {
		if (t->base.dirty_images[face]) {
			r300UploadTexImages(rmesa,
					    (r300TexObjPtr) tObj->DriverData,
					    face);
		}
	}

	if (!t->base.memBlock) {
		/* texmem alloc failed, use s/w fallback */
		return GL_FALSE;
	}

	return GL_TRUE;
}

static GLboolean enable_tex_rect(GLcontext * ctx, int unit)
{
	r300ContextPtr rmesa = R300_CONTEXT(ctx);
	struct gl_texture_unit *texUnit = &ctx->Texture.Unit[unit];
	struct gl_texture_object *tObj = texUnit->_Current;
	r300TexObjPtr t = (r300TexObjPtr) tObj->DriverData;

#if 0
	if (!(t->format & R200_TXFORMAT_NON_POWER2)) {
		t->format |= R200_TXFORMAT_NON_POWER2;
		t->base.dirty_images[0] = ~0;
	}
#endif

	ASSERT(tObj->Target == GL_TEXTURE_RECTANGLE_NV);

	if (t->base.dirty_images[0]) {
		R300_FIREVERTICES(rmesa);
		r300SetTexImages(rmesa, tObj);
		r300UploadTexImages(rmesa, (r300TexObjPtr) tObj->DriverData, 0);
		if (!t->base.memBlock && !rmesa->prefer_gart_client_texturing)
			return GL_FALSE;
	}

	return GL_TRUE;
}

static GLboolean update_tex_common(GLcontext * ctx, int unit)
{
	r300ContextPtr rmesa = R300_CONTEXT(ctx);
	struct gl_texture_unit *texUnit = &ctx->Texture.Unit[unit];
	struct gl_texture_object *tObj = texUnit->_Current;
	r300TexObjPtr t = (r300TexObjPtr) tObj->DriverData;
	GLenum format;

	/* Fallback if there's a texture border */
	if (tObj->Image[0][tObj->BaseLevel]->Border > 0)
		return GL_FALSE;

	/* Update state if this is a different texture object to last
	 * time.
	 */
	if (rmesa->state.texture.unit[unit].texobj != t) {
		if (rmesa->state.texture.unit[unit].texobj != NULL) {
			/* The old texture is no longer bound to this texture unit.
			 * Mark it as such.
			 */

			rmesa->state.texture.unit[unit].texobj->base.bound &=
			    ~(1UL << unit);
		}

		rmesa->state.texture.unit[unit].texobj = t;
		t->base.bound |= (1UL << unit);
		t->dirty_state |= 1 << unit;
		driUpdateTextureLRU((driTextureObject *) t);	/* XXX: should be locked! */
	}

#if 0 /* do elsewhere ? */
	/* Newly enabled?
	 */
	if (1
	    || !(rmesa->hw.ctx.
		 cmd[CTX_PP_CNTL] & (R200_TEX_0_ENABLE << unit))) {
		R300_STATECHANGE(rmesa, ctx);
		rmesa->hw.ctx.cmd[CTX_PP_CNTL] |= (R200_TEX_0_ENABLE |
						   R200_TEX_BLEND_0_ENABLE) <<
		    unit;

		R300_STATECHANGE(rmesa, vtx);
		rmesa->hw.vtx.cmd[VTX_TCL_OUTPUT_VTXFMT_1] |= 4 << (unit * 3);

		rmesa->recheck_texgen[unit] = GL_TRUE;
	}

	if (t->dirty_state & (1 << unit)) {
		import_tex_obj_state(rmesa, unit, t);
	}

	if (rmesa->recheck_texgen[unit]) {
		GLboolean fallback = !r300_validate_texgen(ctx, unit);
		TCL_FALLBACK(ctx, (RADEON_TCL_FALLBACK_TEXGEN_0 << unit),
			     fallback);
		rmesa->recheck_texgen[unit] = 0;
		rmesa->NewGLState |= _NEW_TEXTURE_MATRIX;
	}
#endif

	format = tObj->Image[0][tObj->BaseLevel]->_BaseFormat;
	if (rmesa->state.texture.unit[unit].format != format ||
	    rmesa->state.texture.unit[unit].envMode != texUnit->EnvMode) {
		//rmesa->state.texture.unit[unit].format = format;
		rmesa->state.texture.unit[unit].envMode = texUnit->EnvMode;
		if (!r300UpdateTextureEnv(ctx, unit)) {
			return GL_FALSE;
		}
	}

#if R200_MERGED
	FALLBACK(&rmesa->radeon, RADEON_FALLBACK_BORDER_MODE, t->border_fallback);
#endif
		
	return !t->border_fallback;
}

static GLboolean r300UpdateTextureUnit(GLcontext * ctx, int unit)
{
	struct gl_texture_unit *texUnit = &ctx->Texture.Unit[unit];

	if (texUnit->_ReallyEnabled & (TEXTURE_RECT_BIT)) {
		return (enable_tex_rect(ctx, unit) &&
			update_tex_common(ctx, unit));
	} else if (texUnit->_ReallyEnabled & (TEXTURE_1D_BIT | TEXTURE_2D_BIT)) {
		return (enable_tex_2d(ctx, unit) &&
			update_tex_common(ctx, unit));
	}
#if ENABLE_HW_3D_TEXTURE
	else if (texUnit->_ReallyEnabled & (TEXTURE_3D_BIT)) {
		return (enable_tex_3d(ctx, unit) &&
			update_tex_common(ctx, unit));
	}
#endif
	else if (texUnit->_ReallyEnabled & (TEXTURE_CUBE_BIT)) {
		return (enable_tex_cube(ctx, unit) &&
			update_tex_common(ctx, unit));
	} else if (texUnit->_ReallyEnabled) {
		return GL_FALSE;
	} else {
		disable_tex(ctx, unit);
		return GL_TRUE;
	}
}

void r300UpdateTextureState(GLcontext * ctx)
{
#if 0
	r300ContextPtr rmesa = R300_CONTEXT(ctx);
	GLuint dbg;
	int i;
#endif
	GLboolean ok;

	ok = (r300UpdateTextureUnit(ctx, 0) &&
	      r300UpdateTextureUnit(ctx, 1) &&
	      r300UpdateTextureUnit(ctx, 2) &&
	      r300UpdateTextureUnit(ctx, 3) &&
	      r300UpdateTextureUnit(ctx, 4) &&
	      r300UpdateTextureUnit(ctx, 5) &&
	      r300UpdateTextureUnit(ctx, 6) &&
	      r300UpdateTextureUnit(ctx, 7)
	      );

#if R200_MERGED
	FALLBACK(&rmesa->radeon, RADEON_FALLBACK_TEXTURE, !ok);
#endif	

	/* This needs correction, or just be done elsewhere
	if (rmesa->radeon.TclFallback)
		r300ChooseVertexState(ctx);
	*/

#if 0 /* Workaround - disable.. */
	if (GET_CHIP(rmesa->radeon.radeonScreen) == RADEON_CHIP_REAL_R200) {
		/*
		 * T0 hang workaround -------------
		 * not needed for r200 derivatives?
		 */
		if ((rmesa->hw.ctx.cmd[CTX_PP_CNTL] & R200_TEX_ENABLE_MASK) ==
		    R200_TEX_0_ENABLE
		    && (rmesa->hw.tex[0].
			cmd[TEX_PP_TXFILTER] & R200_MIN_FILTER_MASK) >
		    R200_MIN_FILTER_LINEAR) {

			R300_STATECHANGE(rmesa, ctx);
			R300_STATECHANGE(rmesa, tex[1]);
			rmesa->hw.ctx.cmd[CTX_PP_CNTL] |= R200_TEX_1_ENABLE;
			rmesa->hw.tex[1].cmd[TEX_PP_TXFORMAT] &=
			    ~TEXOBJ_TXFORMAT_MASK;
			rmesa->hw.tex[1].cmd[TEX_PP_TXFORMAT] |= 0x08000000;
		} else {
			if ((rmesa->hw.ctx.cmd[CTX_PP_CNTL] & R200_TEX_1_ENABLE)
			    && (rmesa->hw.tex[1].
				cmd[TEX_PP_TXFORMAT] & 0x08000000)) {
				R300_STATECHANGE(rmesa, tex[1]);
				rmesa->hw.tex[1].cmd[TEX_PP_TXFORMAT] &=
				    ~0x08000000;
			}
		}

		/* maybe needs to be done pairwise due to 2 parallel (physical) tex units ?
		   looks like that's not the case, if 8500/9100 owners don't complain remove this...
		   for ( i = 0; i < ctx->Const.MaxTextureUnits; i += 2) {
		   if (((rmesa->hw.ctx.cmd[CTX_PP_CNTL] & ((R200_TEX_0_ENABLE |
		   R200_TEX_1_ENABLE ) << i)) == (R200_TEX_0_ENABLE << i)) &&
		   ((rmesa->hw.tex[i].cmd[TEX_PP_TXFILTER] & R200_MIN_FILTER_MASK) >
		   R200_MIN_FILTER_LINEAR)) {
		   R300_STATECHANGE(rmesa, ctx);
		   R300_STATECHANGE(rmesa, tex[i+1]);
		   rmesa->hw.ctx.cmd[CTX_PP_CNTL] |= (R200_TEX_1_ENABLE << i);
		   rmesa->hw.tex[i+1].cmd[TEX_PP_TXFORMAT] &= ~TEXOBJ_TXFORMAT_MASK;
		   rmesa->hw.tex[i+1].cmd[TEX_PP_TXFORMAT] |= 0x08000000;
		   }
		   else {
		   if ((rmesa->hw.ctx.cmd[CTX_PP_CNTL] & (R200_TEX_1_ENABLE << i)) &&
		   (rmesa->hw.tex[i+1].cmd[TEX_PP_TXFORMAT] & 0x08000000)) {
		   R300_STATECHANGE(rmesa, tex[i+1]);
		   rmesa->hw.tex[i+1].cmd[TEX_PP_TXFORMAT] &= ~0x08000000;
		   }
		   }
		   } */

		/*
		 * Texture cache LRU hang workaround -------------
		 * not needed for r200 derivatives?
		 */
		dbg = 0x0;

		if (((rmesa->hw.ctx.cmd[CTX_PP_CNTL] & (R200_TEX_0_ENABLE)) &&
		     ((((rmesa->hw.tex[0].
			 cmd[TEX_PP_TXFILTER] & R200_MIN_FILTER_MASK)) & 0x04)
		      == 0))
		    || ((rmesa->hw.ctx.cmd[CTX_PP_CNTL] & R200_TEX_2_ENABLE)
			&&
			((((rmesa->hw.tex[2].
			    cmd[TEX_PP_TXFILTER] & R200_MIN_FILTER_MASK)) &
			  0x04) == 0))
		    || ((rmesa->hw.ctx.cmd[CTX_PP_CNTL] & R200_TEX_4_ENABLE)
			&&
			((((rmesa->hw.tex[4].
			    cmd[TEX_PP_TXFILTER] & R200_MIN_FILTER_MASK)) &
			  0x04) == 0))) {
			dbg |= 0x02;
		}

		if (((rmesa->hw.ctx.cmd[CTX_PP_CNTL] & (R200_TEX_1_ENABLE)) &&
		     ((((rmesa->hw.tex[1].
			 cmd[TEX_PP_TXFILTER] & R200_MIN_FILTER_MASK)) & 0x04)
		      == 0))
		    || ((rmesa->hw.ctx.cmd[CTX_PP_CNTL] & R200_TEX_3_ENABLE)
			&&
			((((rmesa->hw.tex[3].
			    cmd[TEX_PP_TXFILTER] & R200_MIN_FILTER_MASK)) &
			  0x04) == 0))
		    || ((rmesa->hw.ctx.cmd[CTX_PP_CNTL] & R200_TEX_5_ENABLE)
			&&
			((((rmesa->hw.tex[5].
			    cmd[TEX_PP_TXFILTER] & R200_MIN_FILTER_MASK)) &
			  0x04) == 0))) {
			dbg |= 0x04;
		}

		if (dbg != rmesa->hw.tam.cmd[TAM_DEBUG3]) {
			R300_STATECHANGE(rmesa, tam);
			rmesa->hw.tam.cmd[TAM_DEBUG3] = dbg;
			if (0)
				printf("TEXCACHE LRU HANG WORKAROUND %x\n",
				       dbg);
		}
	}
#endif
}