summaryrefslogtreecommitdiff
path: root/src/egl
diff options
context:
space:
mode:
authorChia-I Wu <olvaffe@gmail.com>2010-02-05 13:33:55 +0800
committerChia-I Wu <olvaffe@gmail.com>2010-02-05 13:42:02 +0800
commita37dc17c122ed25365b100aefe4b941df1b526c0 (patch)
treedfd04695b3dd45a9f74fc42f23c55d5294a93ca4 /src/egl
parent1b2b08c5f3a5941151a2f4a8c5da7f214ee979e4 (diff)
egl: Clean up eglconfig.h.
Update the comments to macros/functions. Remove unused _eglSetConfigAttrib.
Diffstat (limited to 'src/egl')
-rw-r--r--src/egl/main/eglconfig.h21
1 files changed, 7 insertions, 14 deletions
diff --git a/src/egl/main/eglconfig.h b/src/egl/main/eglconfig.h
index 09dc61f547..56ec95fe9a 100644
--- a/src/egl/main/eglconfig.h
+++ b/src/egl/main/eglconfig.h
@@ -21,6 +21,9 @@ struct _egl_config
};
+/**
+ * Macros for source level compatibility.
+ */
#define SET_CONFIG_ATTRIB(CONF, ATTR, VAL) _eglSetConfigKey(CONF, ATTR, VAL)
#define GET_CONFIG_ATTRIB(CONF, ATTR) _eglGetConfigKey(CONF, ATTR)
@@ -55,6 +58,10 @@ _eglResetConfigKeys(_EGLConfig *conf, EGLint val)
/**
* Update a config for a given key.
+ *
+ * Note that a valid key is not necessarily a valid attribute. There are gaps
+ * in the attribute enums. The separation is to catch application errors.
+ * Drivers should never set a key that is an invalid attribute.
*/
static INLINE void
_eglSetConfigKey(_EGLConfig *conf, EGLint key, EGLint val)
@@ -77,20 +84,6 @@ _eglGetConfigKey(const _EGLConfig *conf, EGLint key)
}
-/**
- * Set a given attribute.
- *
- * Because _eglGetConfigAttrib is already used as a fallback driver
- * function, this function is not considered to have a good name.
- * SET_CONFIG_ATTRIB is preferred over this function.
- */
-static INLINE void
-_eglSetConfigAttrib(_EGLConfig *conf, EGLint attr, EGLint val)
-{
- SET_CONFIG_ATTRIB(conf, attr, val);
-}
-
-
PUBLIC void
_eglInitConfig(_EGLConfig *config, _EGLDisplay *dpy, EGLint id);